Issue 1153403004: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153403004: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (3/3) (Closed)

Created:
4 years, 11 months ago by Mike West

Modified:
4 years, 11 months ago

Reviewers:
vabr (Chromium), jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@rename-password

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (3/3) This patch cleans up after the rename by dropping the (now unused) WebLocalCredential from Blink's public/platform/. Patch 1 (Blink): https://codereview.chromium.org/1162443006 Patch 2 (Chromium): https://codereview.chromium.org/1162583003 Patch 3 (Blink): [This patch] BUG=494880 R=vabr@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196510

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -83 lines)			Patch
M	Source/platform/blink_platform.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/platform/exported/WebLocalCredential.cpp	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	public/platform/WebLocalCredential.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	public/platform/WebPasswordCredential.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153403004/20001

4 years, 11 months ago (2015-06-04 14:43:06 UTC) #5

commit-bot: I haz the power

4 years, 11 months ago (2015-06-04 16:36:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196510