Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3)

Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (1/3)

As per https://w3c.github.io/webappsec/specs/credentialmanagement/#passwordcredential

This patch doesn't update the interface, it just does the rename. Given
that this touches a jillion files, splitting things up seems reasonable.

Patch 1 (Blink): [This patch]
Patch 2 (Chromium): https://codereview.chromium.org/1162583003
Patch 3 (Blink): https://codereview.chromium.org/1153403004

BUG=494880
R=vabr@chromium.org,jochen@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196341

[Mike West, 2015-06-01 08:49:47]

More. Sorry for the flood. :/

[vabr (Chromium), 2015-06-01 09:10:14]

LGTM FWIW :)
Vaclav

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
File Source/modules/credentialmanager/PasswordCredential.h (right):

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
Source/modules/credentialmanager/PasswordCredential.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
nit: Should you update the copyright year here and in the .cpp file?

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
File Source/modules/credentialmanager/PasswordCredential.idl (right):

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
Source/modules/credentialmanager/PasswordCredential.idl:9: ] interface
PasswordCredential : Credential {
Just to double-check -- as you pointed out in the description, this does not
update the interface, so making the parent a LocallyStoredCredential to match
https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-creden...
will be done in Patch 3 or later, correct?

https://codereview.chromium.org/1162443006/diff/1/Source/platform/credentialm...
File Source/platform/credentialmanager/PlatformPasswordCredential.h (right):

https://codereview.chromium.org/1162443006/diff/1/Source/platform/credentialm...
Source/platform/credentialmanager/PlatformPasswordCredential.h:1: // Copyright
2014 The Chromium Authors. All rights reserved.
nit: Also here and in the associated .cpp, should the year be 2015?

[Mike West, 2015-06-01 09:12:03]

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
File Source/modules/credentialmanager/PasswordCredential.h (right):

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
Source/modules/credentialmanager/PasswordCredential.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/06/01 09:10:13, vabr (Chromium) wrote:
> nit: Should you update the copyright year here and in the .cpp file?

*shrug* Since this just moves `LocalCredential` to `PasswordCredential`, I
didn't think updating the date was justified.

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
File Source/modules/credentialmanager/PasswordCredential.idl (right):

https://codereview.chromium.org/1162443006/diff/1/Source/modules/credentialma...
Source/modules/credentialmanager/PasswordCredential.idl:9: ] interface
PasswordCredential : Credential {
On 2015/06/01 at 09:10:13, vabr (Chromium) wrote:
> Just to double-check -- as you pointed out in the description, this does not
update the interface, so making the parent a LocallyStoredCredential to match
https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-creden...
will be done in Patch 3 or later, correct?

That will be done in patch #17. It will introduce a lot of churn, so I'm
avoiding it.

https://codereview.chromium.org/1162443006/diff/1/Source/platform/credentialm...
File Source/platform/credentialmanager/PlatformPasswordCredential.h (right):

https://codereview.chromium.org/1162443006/diff/1/Source/platform/credentialm...
Source/platform/credentialmanager/PlatformPasswordCredential.h:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2015/06/01 at 09:10:13, vabr (Chromium) wrote:
> nit: Also here and in the associated .cpp, should the year be 2015?

Same as above.

[jochen (gone - plz use gerrit), 2015-06-01 13:09:07]

lgtm

[Mike West, 2015-06-02 13:05:18]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-06-02 13:05:19]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1162443006/#ps20001
(title: "Test.")

[commit-bot: I haz the power, 2015-06-02 13:05:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162443006/20001

[commit-bot: I haz the power, 2015-06-02 14:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 14:49:19]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Mike West, 2015-06-02 15:13:54]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-02 15:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162443006/20001

[commit-bot: I haz the power, 2015-06-02 16:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:50:11]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Mike West, 2015-06-02 19:24:16]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-02 19:24:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1162443006/20001

[commit-bot: I haz the power, 2015-06-02 20:12:40]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196341