components/password_manager/content/renderer/credential_manager_client.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_content_utils.cc ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index b57d3100b2ac1500533dd18f3a64ce9692b33410..66754a7bcc82d35f70743f5f57041d42aa501786 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -11,7 +11,7 @@

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

#include "third_party/WebKit/public/platform/WebFederatedCredential.h"

-#include "third_party/WebKit/public/platform/WebLocalCredential.h"

+#include "third_party/WebKit/public/platform/WebPasswordCredential.h"

#include "third_party/WebKit/public/web/WebView.h"

namespace password_manager {

@@ -87,8 +87,8 @@ void CredentialManagerClient::OnSendCredential(int request_id,

credential.reset(new blink::WebFederatedCredential(

info.id, info.federation, info.name, info.avatar));

break;

- case CredentialType::CREDENTIAL_TYPE_LOCAL:

- credential.reset(new blink::WebLocalCredential(

+ case CredentialType::CREDENTIAL_TYPE_PASSWORD:

+ credential.reset(new blink::WebPasswordCredential(

info.id, info.password, info.name, info.avatar));

break;

case CredentialType::CREDENTIAL_TYPE_EMPTY: