components/password_manager/core/common/credential_manager_types.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/common/credential_manager_types.h ('k') | components/password_manager/core/common/credential_manager_types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types.cc

diff --git a/components/password_manager/core/common/credential_manager_types.cc b/components/password_manager/core/common/credential_manager_types.cc

index cc43c52f2b8e433144e3346370d4d43817b7d178..5e4f5b5f95386dcf2d9a4b2894a2a35b2f68f733 100644

--- a/components/password_manager/core/common/credential_manager_types.cc

+++ b/components/password_manager/core/common/credential_manager_types.cc

@@ -25,7 +25,7 @@ CredentialInfo::CredentialInfo(const autofill::PasswordForm& form,

password = base::string16();

federation = GURL();

break;

- case CredentialType::CREDENTIAL_TYPE_LOCAL:

+ case CredentialType::CREDENTIAL_TYPE_PASSWORD:

federation = GURL();

break;

case CredentialType::CREDENTIAL_TYPE_FEDERATED:

@@ -54,7 +54,7 @@ scoped_ptr<autofill::PasswordForm> CreatePasswordFormFromCredentialInfo(

form->scheme = autofill::PasswordForm::SCHEME_HTML;

form->signon_realm =

- info.type == CredentialType::CREDENTIAL_TYPE_LOCAL

+ info.type == CredentialType::CREDENTIAL_TYPE_PASSWORD

? origin.spec()

: "federation://" + origin.host() + "/" + info.federation.host();

form->username_value = info.id;