components/password_manager/content/common/credential_manager_content_utils.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_content_utils.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/content/renderer/credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_content_utils.cc

diff --git a/components/password_manager/content/common/credential_manager_content_utils.cc b/components/password_manager/content/common/credential_manager_content_utils.cc

index 49a24e80f9e57a3a5457264290c1c456bfaf52a8..ce3d6cf6d1040c517e76190a74869cf4bdd3a279 100644

--- a/components/password_manager/content/common/credential_manager_content_utils.cc

+++ b/components/password_manager/content/common/credential_manager_content_utils.cc

@@ -7,7 +7,7 @@

#include "base/logging.h"

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebFederatedCredential.h"

-#include "third_party/WebKit/public/platform/WebLocalCredential.h"

+#include "third_party/WebKit/public/platform/WebPasswordCredential.h"

namespace password_manager {

@@ -17,13 +17,13 @@ CredentialInfo WebCredentialToCredentialInfo(

credential_info.id = credential.id();

credential_info.name = credential.name();

credential_info.avatar = credential.avatarURL();

- credential_info.type = credential.isLocalCredential()

- ? CredentialType::CREDENTIAL_TYPE_LOCAL

+ credential_info.type = credential.isPasswordCredential()

+ ? CredentialType::CREDENTIAL_TYPE_PASSWORD

: CredentialType::CREDENTIAL_TYPE_FEDERATED;

- if (credential_info.type == CredentialType::CREDENTIAL_TYPE_LOCAL) {

- DCHECK(credential.isLocalCredential());

+ if (credential_info.type == CredentialType::CREDENTIAL_TYPE_PASSWORD) {

+ DCHECK(credential.isPasswordCredential());

credential_info.password =

- static_cast<const blink::WebLocalCredential&>(credential).password();

+ static_cast<const blink::WebPasswordCredential&>(credential).password();

} else {

DCHECK(credential.isFederatedCredential());

credential_info.federation =