components/password_manager/content/renderer/credential_manager_client_browsertest.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

index 443a25acb9cad387f41c8d74dc99d7086b51598a..926755f02774b7c7c75d32b4ffa7c366b6bca1e3 100644

--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc

@@ -10,7 +10,7 @@

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

-#include "third_party/WebKit/public/platform/WebLocalCredential.h"

+#include "third_party/WebKit/public/platform/WebPasswordCredential.h"

namespace password_manager {

@@ -33,7 +33,7 @@ class MAYBE_CredentialManagerClientTest : public content::RenderViewTest {

void SetUp() override {

content::RenderViewTest::SetUp();

- credential_.reset(new blink::WebLocalCredential("", "", GURL(), ""));

+ credential_.reset(new blink::WebPasswordCredential("", "", "", GURL()));

client_.reset(new CredentialManagerClient(view_));

}

@@ -112,7 +112,7 @@ class MAYBE_CredentialManagerClientTest : public content::RenderViewTest {

bool callback_errored_;

bool callback_succeeded_;

- scoped_ptr<blink::WebLocalCredential> credential_;

+ scoped_ptr<blink::WebPasswordCredential> credential_;

};

class TestNotificationCallbacks

@@ -219,7 +219,7 @@ TEST_F(MAYBE_CredentialManagerClientTest, SendRequestCredential) {

request_id));

CredentialInfo info;

- info.type = CredentialType::CREDENTIAL_TYPE_LOCAL;

+ info.type = CredentialType::CREDENTIAL_TYPE_PASSWORD;

client_->OnSendCredential(request_id, info);

EXPECT_TRUE(callback_succeeded());

EXPECT_FALSE(callback_errored());