chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index b5c95902d2820cc498950a2bf2b6f897203868b2..101db294939991d723b0f3a1390a57e464263278 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -218,16 +218,16 @@ void ManagePasswordsUIController::ChooseCredential(

// a FederatedCredential in order to prevent password information leaking

// cross-origin.

- // If |credential_type| is local, the credential MIGHT be a LocalCredential

+ // If |credential_type| is local, the credential MIGHT be a PasswordCredential

// or it MIGHT be a FederatedCredential. We inspect the |federation_url|

// field to determine which we should return.

// TODO(mkwst): Clean this up. It is confusing.

password_manager::CredentialType type_to_return;

if (credential_type ==

- password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL &&

+ password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD &&

form.federation_url.is_empty()) {

- type_to_return = password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL;

+ type_to_return = password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD;

} else if (credential_type ==

password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY) {

type_to_return = password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY;