components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1162583003: Credential Management: Rename 'LocalCredential' to 'PasswordCredential' (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drop

Patch Set: Fix. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client_browsertest.cc ('k') | components/password_manager/core/common/credential_manager_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index 596ed0a07843a90292625a9b3e02242b06f9af8f..68e03c1cfe0510e479a57797e0b075f9c201cdb3 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -78,7 +78,7 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

zero_click_form_to_return);

CredentialInfo info(*zero_click_form_to_return,

zero_click_form_to_return->federation_url.is_empty()

- ? CredentialType::CREDENTIAL_TYPE_LOCAL

+ ? CredentialType::CREDENTIAL_TYPE_PASSWORD

: CredentialType::CREDENTIAL_TYPE_FEDERATED);

DCHECK(it != local_results.end());

std::swap(*it, local_results[0]);