Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed)

Created:
8 years ago by tfarina
Modified:
8 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, yusukes+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Evan review #

Total comments: 4

Patch Set 3 : fixes #

Total comments: 2

Patch Set 4 : more work #

Patch Set 5 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -131 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 3 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_options_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_options_util.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 3 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 2 9 chunks +32 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
Hi Evan, could you review this to me? Thanks,
8 years ago (2012-11-30 14:13:04 UTC) #1
Evan Stade
thanks for doing this. Can you also go back and fix my comment from https://chromiumcodereview.appspot.com/11299122/ ...
8 years ago (2012-11-30 20:15:56 UTC) #2
tfarina
On 2012/11/30 20:15:56, Evan Stade wrote: > thanks for doing this. Can you also go ...
8 years ago (2012-11-30 22:41:08 UTC) #3
Evan Stade
https://codereview.chromium.org/11415226/diff/5001/chrome/browser/ui/webui/options/content_settings_handler.cc File chrome/browser/ui/webui/options/content_settings_handler.cc (right): https://codereview.chromium.org/11415226/diff/5001/chrome/browser/ui/webui/options/content_settings_handler.cc#newcode1249 chrome/browser/ui/webui/options/content_settings_handler.cc:1249: scoped_ptr<Value> type_value(new base::StringValue(type_string)); why do these still exist https://codereview.chromium.org/11415226/diff/5001/chrome/browser/ui/webui/options/preferences_browsertest.cc ...
8 years ago (2012-11-30 22:47:00 UTC) #4
tfarina
https://codereview.chromium.org/11415226/diff/5001/chrome/browser/ui/webui/options/content_settings_handler.cc File chrome/browser/ui/webui/options/content_settings_handler.cc (right): https://codereview.chromium.org/11415226/diff/5001/chrome/browser/ui/webui/options/content_settings_handler.cc#newcode1249 chrome/browser/ui/webui/options/content_settings_handler.cc:1249: scoped_ptr<Value> type_value(new base::StringValue(type_string)); On 2012/11/30 22:47:00, Evan Stade wrote: ...
8 years ago (2012-11-30 23:07:31 UTC) #5
Evan Stade
https://codereview.chromium.org/11415226/diff/8002/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc File chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc (right): https://codereview.chromium.org/11415226/diff/8002/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc#newcode83 chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc:83: option->Append(Value::CreateIntegerValue(value)); please change them in all the files
8 years ago (2012-12-03 18:44:25 UTC) #6
tfarina
https://codereview.chromium.org/11415226/diff/8002/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc File chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc (right): https://codereview.chromium.org/11415226/diff/8002/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc#newcode83 chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc:83: option->Append(Value::CreateIntegerValue(value)); On 2012/12/03 18:44:26, Evan Stade wrote: > please ...
8 years ago (2012-12-03 18:58:47 UTC) #7
Evan Stade
lgtm, thanks
8 years ago (2012-12-03 21:34:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11415226/11002
8 years ago (2012-12-03 23:32:39 UTC) #9
commit-bot: I haz the power
Presubmit check for 11415226-11002 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-03 23:32:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11415226/11002
8 years ago (2012-12-03 23:52:14 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 05:38:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11415226/11002
8 years ago (2012-12-04 09:41:31 UTC) #13
commit-bot: I haz the power
8 years ago (2012-12-04 11:58:27 UTC) #14
Message was sent while issue was closed. 
Change committed as 170936

Powered by Google App Engine
This is Rietveld 408576698