webui/options: Do not use Value::CreateStringValue.

chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/keyboard_handler.h"
 
 #include "base/command_line.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/input_method/xkeyboard.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 62 matching lines @@
       const input_method::ModifierKey value =
           kModifierKeysSelectItems[j].value;
       const int message_id = kModifierKeysSelectItems[j].message_id;
       // Only the seach key can be remapped to the caps lock key.
       if (kDataValuesNames[i] != std::string("remapSearchKeyToValue") &&
           kDataValuesNames[i] != std::string("remapCapsLockKeyToValue") &&
           value == input_method::kCapsLockKey) {
         continue;
       }
       ListValue* option = new ListValue();
       option->Append(Value::CreateIntegerValue(value));

[Evan Stade, 2012/12/03 18:44:26]

please change them in all the files

[tfarina, 2012/12/03 18:58:48]

Done.

-      option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(
+      option->Append(new base::StringValue(l10n_util::GetStringUTF16(
           message_id)));
       list_value->Append(option);
     }
     localized_strings->Set(kDataValuesNames[i], list_value);
   }
 }
 
 void KeyboardHandler::InitializePage() {
   bool chromeos_keyboard = CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kHasChromeOSKeyboard);
   bool chromebook_function_key = CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableChromebookFunctionKey);
 
   const base::FundamentalValue show_options(true);
 
   if (!chromeos_keyboard) {
     web_ui()->CallJavascriptFunction(
         "options.KeyboardOverlay.showCapsLockOptions", show_options);
   }
 
   if (chromeos_keyboard && chromebook_function_key) {
     web_ui()->CallJavascriptFunction(
         "options.KeyboardOverlay.showFunctionKeyOptions", show_options);
   }
 }
 
 }  // namespace options
 }  // namespace chromeos