Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: chrome/browser/ui/webui/options/manage_profile_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc
index d878e3a73d661cba1f9d4fc951444dfe0c59cfe6..3b1bf57b9d575e825bf963458b9ba5c8f5532ca7 100644
--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc
@@ -124,14 +124,14 @@ void ManageProfileHandler::SendProfileIcons(
if (icon) {
gfx::Image icon2 = profiles::GetAvatarIconForWebUI(*icon, true);
gaia_picture_url_ = web_ui_util::GetBitmapDataUrl(icon2.AsBitmap());
- image_url_list.Append(Value::CreateStringValue(gaia_picture_url_));
+ image_url_list.Append(new base::StringValue(gaia_picture_url_));
}
}
// Next add the default avatar icons.
for (size_t i = 0; i < ProfileInfoCache::GetDefaultAvatarIconCount(); i++) {
std::string url = ProfileInfoCache::GetDefaultAvatarIconUrl(i);
- image_url_list.Append(Value::CreateStringValue(url));
+ image_url_list.Append(new base::StringValue(url));
}
web_ui()->CallJavascriptFunction(

Powered by Google App Engine
This is Rietveld 408576698