webui/options: Do not use Value::CreateStringValue.

chrome/browser/ui/webui/options/core_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/core_options_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 267 matching lines @@
   DispatchPrefChangeNotification(pref_name, value.Pass());
 }
 
 void CoreOptionsHandler::DispatchPrefChangeNotification(
     const std::string& name,
     scoped_ptr<base::Value> value) {
   std::pair<PreferenceCallbackMap::const_iterator,
             PreferenceCallbackMap::const_iterator> range =
       pref_callback_map_.equal_range(name);
   ListValue result_value;
-  result_value.Append(base::Value::CreateStringValue(name.c_str()));
+  result_value.Append(new base::StringValue(name.c_str()));
   result_value.Append(value.release());
   for (PreferenceCallbackMap::const_iterator iter = range.first;
        iter != range.second; ++iter) {
     const std::string& callback_function = iter->second;
     web_ui()->CallJavascriptFunction(callback_function, result_value);
   }
 }
 
 base::Value* CoreOptionsHandler::CreateValueForPref(
     const std::string& pref_name,
@@ skipping 157 matching lines @@
 
   switch (type) {
     case TYPE_BOOLEAN:
       CHECK_EQ(base::Value::TYPE_BOOLEAN, value->GetType());
       break;
     case TYPE_INTEGER: {
       // In JS all numbers are doubles.
       double double_value;
       CHECK(value->GetAsDouble(&double_value));
       int int_value = static_cast<int>(double_value);
-      temp_value.reset(base::Value::CreateIntegerValue(int_value));
+      temp_value.reset(new base::FundamentalValue(int_value));
       value = temp_value.get();
       break;
     }
     case TYPE_DOUBLE:
       CHECK_EQ(base::Value::TYPE_DOUBLE, value->GetType());
       break;
     case TYPE_STRING:
       CHECK_EQ(base::Value::TYPE_STRING, value->GetType());
       break;
     case TYPE_URL: {
       std::string original;
       CHECK(value->GetAsString(&original));
       GURL fixed = URLFixerUpper::FixupURL(original, std::string());
-      temp_value.reset(base::Value::CreateStringValue(fixed.spec()));
+      temp_value.reset(new base::StringValue(fixed.spec()));
       value = temp_value.get();
       break;
     }
     case TYPE_LIST: {
       // In case we have a List pref we got a JSON string.
       std::string json_string;
       CHECK(value->GetAsString(&json_string));
       temp_value.reset(
           base::JSONReader::Read(json_string));
       value = temp_value.get();
@@ skipping 26 matching lines @@
   ClearPref(pref_name, metric);
 }
 
 void CoreOptionsHandler::HandleUserMetricsAction(const ListValue* args) {
   std::string metric = UTF16ToUTF8(ExtractStringValue(args));
   if (!metric.empty())
     content::RecordComputedAction(metric);
 }
 
 void CoreOptionsHandler::UpdateClearPluginLSOData() {
-  scoped_ptr<base::Value> enabled(
-      base::Value::CreateBooleanValue(
-          plugin_status_pref_setter_.IsClearPluginLSODataEnabled()));
+  base::FundamentalValue enabled(
+          plugin_status_pref_setter_.IsClearPluginLSODataEnabled());
   web_ui()->CallJavascriptFunction(
-      "OptionsPage.setClearPluginLSODataEnabled", *enabled);
+      "OptionsPage.setClearPluginLSODataEnabled", enabled);
 }
 
 void CoreOptionsHandler::UpdatePepperFlashSettingsEnabled() {
-  scoped_ptr<base::Value> enabled(
-      base::Value::CreateBooleanValue(
-          plugin_status_pref_setter_.IsPepperFlashSettingsEnabled()));
+  base::FundamentalValue enabled(
+          plugin_status_pref_setter_.IsPepperFlashSettingsEnabled());
   web_ui()->CallJavascriptFunction(
-      "OptionsPage.setPepperFlashSettingsEnabled", *enabled);
+      "OptionsPage.setPepperFlashSettingsEnabled", enabled);
 }
 
 }  // namespace options