chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc - Issue 11415226: webui/options: Do not use Value::CreateStringValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix typo Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/language_options_util.cc ('k') | chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc b/chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc

index 099c2936ee796a4592afac028d6b89b5ee204d17..3fe196f8b1c19977ffbc48849ad445f6531afd38 100644

--- a/chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc

@@ -51,10 +51,10 @@ void LanguagePinyinHandler::GetLocalizedValues(

item_message_id == 0)

break;

ListValue* option = new ListValue();

- option->Append(Value::CreateIntegerValue(

+ option->Append(new base::FundamentalValue(

language_prefs::kPinyinDoublePinyinSchema.values_and_ids[i].

ibus_config_value));

- option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(

+ option->Append(new base::StringValue(l10n_util::GetStringUTF16(

language_prefs::kPinyinDoublePinyinSchema.values_and_ids[i].

item_message_id)));

list_value->Append(option);