Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8628)

Unified Diff: chrome/browser/ui/webui/options/font_settings_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/font_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/font_settings_handler.cc b/chrome/browser/ui/webui/options/font_settings_handler.cc
index c98ef2468003d130a9f8d2d8d9f923223e7ac296..f82aaf7e649cf25ed9e12635e15093005952190f 100644
--- a/chrome/browser/ui/webui/options/font_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/font_settings_handler.cc
@@ -161,7 +161,7 @@ void FontSettingsHandler::FontsListHasLoaded(
bool has_value = font->GetString(1, &value);
DCHECK(has_value);
bool has_rtl_chars = base::i18n::StringContainsStrongRTLChars(value);
- font->Append(Value::CreateStringValue(has_rtl_chars ? "rtl" : "ltr"));
+ font->Append(new base::StringValue(has_rtl_chars ? "rtl" : "ltr"));
}
ListValue encoding_list;
@@ -183,27 +183,27 @@ void FontSettingsHandler::FontsListHasLoaded(
CharacterEncoding::GetCanonicalEncodingNameByCommandId(cmd_id);
string16 name = it->encoding_display_name;
bool has_rtl_chars = base::i18n::StringContainsStrongRTLChars(name);
- option->Append(Value::CreateStringValue(encoding));
- option->Append(Value::CreateStringValue(name));
- option->Append(Value::CreateStringValue(has_rtl_chars ? "rtl" : "ltr"));
+ option->Append(new base::StringValue(encoding));
+ option->Append(new base::StringValue(name));
+ option->Append(new base::StringValue(has_rtl_chars ? "rtl" : "ltr"));
} else {
// Add empty name/value to indicate a separator item.
- option->Append(Value::CreateStringValue(""));
- option->Append(Value::CreateStringValue(""));
+ option->Append(new base::StringValue(""));
+ option->Append(new base::StringValue(""));
}
encoding_list.Append(option);
}
ListValue selected_values;
- selected_values.Append(Value::CreateStringValue(MaybeGetLocalizedFontName(
+ selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
standard_font_.GetValue())));
- selected_values.Append(Value::CreateStringValue(MaybeGetLocalizedFontName(
+ selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
serif_font_.GetValue())));
- selected_values.Append(Value::CreateStringValue(MaybeGetLocalizedFontName(
+ selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
sans_serif_font_.GetValue())));
- selected_values.Append(Value::CreateStringValue(MaybeGetLocalizedFontName(
+ selected_values.Append(new base::StringValue(MaybeGetLocalizedFontName(
fixed_font_.GetValue())));
- selected_values.Append(Value::CreateStringValue(font_encoding_.GetValue()));
+ selected_values.Append(new base::StringValue(font_encoding_.GetValue()));
web_ui()->CallJavascriptFunction("FontSettings.setFontsData",
*list.get(), encoding_list,
« no previous file with comments | « chrome/browser/ui/webui/options/core_options_handler.cc ('k') | chrome/browser/ui/webui/options/handler_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698