Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
index 2672e3311f6e4a2e12461b7de95bb80c6bfe06b8..39506dddc9e75e0a4aafd848d55b8c80f5fe0915 100644
--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
@@ -520,7 +520,7 @@ void PopulateVPNDetails(
chromeos::onc::kVPN,
chromeos::onc::vpn::kHost));
SetValueDictionary(dictionary, kTagServerHostname,
- Value::CreateStringValue(vpn->server_hostname()),
+ new base::StringValue(vpn->server_hostname()),
hostname_ui_data);
}
@@ -1311,7 +1311,7 @@ void InternetOptionsHandler::PopulateIPConfigsCallback(
dictionary.SetBoolean(kTagShowPreferred,
network_profile == chromeos::PROFILE_USER);
SetValueDictionary(&dictionary, kTagPreferred,
- Value::CreateBooleanValue(network->preferred()),
+ new base::FundamentalValue(network->preferred()),
property_ui_data);
chromeos::NetworkPropertyUIData auto_connect_ui_data(ui_data);
@@ -1323,7 +1323,7 @@ void InternetOptionsHandler::PopulateIPConfigsCallback(
chromeos::onc::wifi::kAutoConnect));
}
SetValueDictionary(&dictionary, kTagAutoConnect,
- Value::CreateBooleanValue(network->auto_connect()),
+ new base::FundamentalValue(network->auto_connect()),
auto_connect_ui_data);
if (type == chromeos::TYPE_WIFI) {
@@ -1444,7 +1444,7 @@ void InternetOptionsHandler::PopulateCellularDetails(
device->technology_family() == chromeos::TECHNOLOGY_FAMILY_GSM);
SetValueDictionary(
dictionary, kTagSimCardLockEnabled,
- Value::CreateBooleanValue(
+ new base::FundamentalValue(
device->sim_pin_required() == chromeos::SIM_PIN_REQUIRED),
cellular_property_ui_data);

Powered by Google App Engine
This is Rietveld 408576698