webui/options: Do not use Value::CreateStringValue.

chrome/browser/ui/webui/options/content_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 1228 matching lines @@
   ExContentSettingsType type = ExContentSettingsTypeFromGroupName(type_string);
   bool is_valid = false;
   if (type == EX_CONTENT_SETTINGS_TYPE_PEPPER_FLASH_CAMERAMIC) {
     is_valid = IsValidHost(pattern_string);
   } else {
     ContentSettingsPattern pattern =
         ContentSettingsPattern::FromString(pattern_string);
     is_valid = pattern.IsValid();
   }
 
-  scoped_ptr<Value> type_value(Value::CreateStringValue(type_string));
-  scoped_ptr<Value> mode_value(Value::CreateStringValue(mode_string));
-  scoped_ptr<Value> pattern_value(Value::CreateStringValue(pattern_string));
+  scoped_ptr<Value> type_value(new base::StringValue(type_string));

[Evan Stade, 2012/11/30 22:47:00]

why do these still exist

[tfarina, 2012/11/30 23:07:31]

Done.

+  scoped_ptr<Value> mode_value(new base::StringValue(mode_string));
+  scoped_ptr<Value> pattern_value(new base::StringValue(pattern_string));
   scoped_ptr<Value> valid_value(Value::CreateBooleanValue(is_valid));
 
   web_ui()->CallJavascriptFunction(
       "ContentSettings.patternValidityCheckComplete",
-      *type_value.get(),
-      *mode_value.get(),
-      *pattern_value.get(),
-      *valid_value.get());
+      base::StringValue(type_string),
+      base::StringValue(mode_string),
+      base::StringValue(pattern_string),
+      base::FundamentalValue(is_valid));
 }
 
 // static
 std::string ContentSettingsHandler::ContentSettingsTypeToGroupName(
     ContentSettingsType type) {
   return ExContentSettingsTypeToGroupName(ExContentSettingsType(type));
 }
 
 HostContentSettingsMap* ContentSettingsHandler::GetContentSettingsMap() {
   return Profile::FromWebUI(web_ui())->GetHostContentSettingsMap();
@@ skipping 42 matching lines @@
   for (size_t i = 0; i < arraysize(kExContentSettingsTypeGroupNames); ++i) {
     if (type == kExContentSettingsTypeGroupNames[i].type)
       return kExContentSettingsTypeGroupNames[i].name;
   }
 
   NOTREACHED();
   return std::string();
 }
 
 }  // namespace options