chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc - Issue 11415226: webui/options: Do not use Value::CreateStringValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix typo Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

index 88e331b69cc7639b0c557d8043191c723933b32d..18ddf572e0041f60249dfa070d3389eedba5d49b 100644

--- a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

@@ -83,8 +83,8 @@ void KeyboardHandler::GetLocalizedValues(DictionaryValue* localized_strings) {

continue;

}

ListValue* option = new ListValue();

- option->Append(Value::CreateIntegerValue(value));

- option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(

+ option->Append(new base::FundamentalValue(value));

+ option->Append(new base::StringValue(l10n_util::GetStringUTF16(

message_id)));

list_value->Append(option);

}