cc: Use gfx:: Geometry types for positions, bounds, and related things.

cc: Use gfx:: Geometry types for positions, bounds, and related things.

This covers layers, layer tree hosts, and related classes. *phew*

I intentionally avoided anything to do with scrolling or page scale. Those
should be changed to be Vectors and need a bit more thought. This change
should be pretty mindless.

It converts to gfx Rect, Size, Vector, and Point classes. No change is
made for FloatPoint3D or FloatQuad yet.

I've added cc/geometry.h as a place for free functions that don't exist
on gfx types yet, and that we should port over in the future.

No change in behaviour; covered by existing tests.

BUG=147395
R=enne

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165434

[danakj, 2012-10-26 02:56:36]

This depends on the Vector2d CL https://codereview.chromium.org/11269022/ as
well as the non-mutating methods CL https://codereview.chromium.org/11270042/

[enne (OOO), 2012-10-29 22:23:46]

lgtm

http://codereview.chromium.org/11264056/diff/6001/cc/layer_quad.h
File cc/layer_quad.h (right):

http://codereview.chromium.org/11264056/diff/6001/cc/layer_quad.h#newcode65
cc/layer_quad.h:65: return FloatPoint(
Don't rely on implicit conversion here.

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc
File cc/layer_tiling_data.cc (right):

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc#new...
cc/layer_tiling_data.cc:148: return cc::IntSize(m_tilingData.totalSize());
Construct a gfx::Size to return.

[danakj, 2012-10-31 19:45:43]

http://codereview.chromium.org/11264056/diff/6001/cc/layer_quad.h
File cc/layer_quad.h (right):

http://codereview.chromium.org/11264056/diff/6001/cc/layer_quad.h#newcode65
cc/layer_quad.h:65: return FloatPoint(
On 2012/10/29 22:23:47, enne wrote:
> Don't rely on implicit conversion here.

Oh, thanks. I just missed that one.

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc
File cc/layer_tiling_data.cc (right):

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc#new...
cc/layer_tiling_data.cc:148: return cc::IntSize(m_tilingData.totalSize());
On 2012/10/29 22:23:47, enne wrote:
> Construct a gfx::Size to return.

I wanted to do this because we can search-replace and remove all cc::IntSize()
later. Whereas if we have a gfx::Size construction, we won't always find that
later once this thing returns a gfx::Size.

[enne (OOO), 2012-10-31 20:41:56]

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc
File cc/layer_tiling_data.cc (right):

http://codereview.chromium.org/11264056/diff/6001/cc/layer_tiling_data.cc#new...
cc/layer_tiling_data.cc:148: return cc::IntSize(m_tilingData.totalSize());
On 2012/10/31 19:45:43, danakj wrote:
> On 2012/10/29 22:23:47, enne wrote:
> > Construct a gfx::Size to return.
> 
> I wanted to do this because we can search-replace and remove all cc::IntSize()
> later. Whereas if we have a gfx::Size construction, we won't always find that
> later once this thing returns a gfx::Size.

Ah, right.  I forgot that totalSize returned a WebCore::IntSize, so you can't
convert to gfx::Size directly.

[commit-bot: I haz the power, 2012-10-31 23:45:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11264056/25117

[tfarina, 2012-11-01 01:51:22]

https://codereview.chromium.org/11264056/diff/15032/cc/font_atlas.h
File cc/font_atlas.h (right):

https://codereview.chromium.org/11264056/diff/15032/cc/font_atlas.h#newcode13
cc/font_atlas.h:13: #include "ui/gfx/rect.h"
do'h! I had a patch here for this!! :(

[danakj, 2012-11-01 01:52:39]

https://codereview.chromium.org/11264056/diff/15032/cc/font_atlas.h
File cc/font_atlas.h (right):

https://codereview.chromium.org/11264056/diff/15032/cc/font_atlas.h#newcode13
cc/font_atlas.h:13: #include "ui/gfx/rect.h"
On 2012/11/01 01:51:22, tfarina wrote:
> do'h! I had a patch here for this!! :(

Oh :( Ya I threw this one up last week, but it's been gated on the vector stuff.

[tfarina, 2012-11-01 01:54:34]

https://codereview.chromium.org/11264056/diff/23129/cc/layer.cc
File cc/layer.cc (right):

https://codereview.chromium.org/11264056/diff/23129/cc/layer.cc#newcode833
cc/layer.cc:833: return cc::IntRect(visibleContentRect());
nit: no cc:: here, as we are in cc namespace.

[danakj, 2012-11-01 01:55:38]

https://codereview.chromium.org/11264056/diff/23129/cc/layer.cc
File cc/layer.cc (right):

https://codereview.chromium.org/11264056/diff/23129/cc/layer.cc#newcode833
cc/layer.cc:833: return cc::IntRect(visibleContentRect());
On 2012/11/01 01:54:34, tfarina wrote:
> nit: no cc:: here, as we are in cc namespace.

I'm just doing this to be explicit so we can easily see "IntRect" -> things to
convert to gfx::Rect, vs "cc::IntRect" -> conversions that should just be
deleted once all the types are done.