Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1126013003: v8::Isolate* should be the first parameter (Closed)

Created:
5 years, 7 months ago by Shiva Samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, falken, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

v8::Isolate* should be the first parameter wrap function change : As v8::isolate is not a optional argument anymore, move isolate to first argumnet of methods in bindings BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195049

Patch Set 1 : Wrap function Change for v8::Isolate* , as it is no more optional argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M Source/bindings/core/v8/ScriptWrappable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ToV8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBufferView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMDataView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMDataView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTypedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTypedArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Shiva Samsung
PTAL?
5 years, 7 months ago (2015-05-07 09:56:22 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-07 10:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126013003/1
5 years, 7 months ago (2015-05-07 11:37:23 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 13:07:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195049

Powered by Google App Engine
This is Rietveld 408576698