Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: Source/core/dom/DOMDataView.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DOMDataView.h ('k') | Source/core/dom/DOMTypedArray.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/dom/DOMDataView.h" 6 #include "core/dom/DOMDataView.h"
7 7
8 #include "bindings/core/v8/DOMDataStore.h" 8 #include "bindings/core/v8/DOMDataStore.h"
9 #include "bindings/core/v8/V8ArrayBuffer.h" 9 #include "bindings/core/v8/V8ArrayBuffer.h"
10 #include "bindings/core/v8/V8DOMWrapper.h" 10 #include "bindings/core/v8/V8DOMWrapper.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 PassRefPtr<DOMDataView> DOMDataView::create(PassRefPtr<DOMArrayBuffer> prpBuffer , unsigned byteOffset, unsigned byteLength) 14 PassRefPtr<DOMDataView> DOMDataView::create(PassRefPtr<DOMArrayBuffer> prpBuffer , unsigned byteOffset, unsigned byteLength)
15 { 15 {
16 RefPtr<DOMArrayBuffer> buffer = prpBuffer; 16 RefPtr<DOMArrayBuffer> buffer = prpBuffer;
17 RefPtr<DataView> dataView = DataView::create(buffer->buffer(), byteOffset, b yteLength); 17 RefPtr<DataView> dataView = DataView::create(buffer->buffer(), byteOffset, b yteLength);
18 return adoptRef(new DOMDataView(dataView.release(), buffer.release())); 18 return adoptRef(new DOMDataView(dataView.release(), buffer.release()));
19 } 19 }
20 20
21 v8::Local<v8::Object> DOMDataView::wrap(v8::Local<v8::Object> creationContext, v 8::Isolate* isolate) 21 v8::Local<v8::Object> DOMDataView::wrap(v8::Isolate* isolate, v8::Local<v8::Obje ct> creationContext)
22 { 22 {
23 // It's possible that no one except for the new wrapper owns this object at 23 // It's possible that no one except for the new wrapper owns this object at
24 // this moment, so we have to prevent GC to collect this object until the 24 // this moment, so we have to prevent GC to collect this object until the
25 // object gets associated with the wrapper. 25 // object gets associated with the wrapper.
26 RefPtr<DOMDataView> protect(this); 26 RefPtr<DOMDataView> protect(this);
27 27
28 ASSERT(!DOMDataStore::containsWrapper(this, isolate)); 28 ASSERT(!DOMDataStore::containsWrapper(this, isolate));
29 29
30 const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo(); 30 const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();
31 v8::Local<v8::Value> v8Buffer = toV8(buffer(), creationContext, isolate); 31 v8::Local<v8::Value> v8Buffer = toV8(buffer(), creationContext, isolate);
32 ASSERT(v8Buffer->IsArrayBuffer()); 32 ASSERT(v8Buffer->IsArrayBuffer());
33 33
34 v8::Local<v8::Object> wrapper = v8::DataView::New(v8Buffer.As<v8::ArrayBuffe r>(), byteOffset(), byteLength()); 34 v8::Local<v8::Object> wrapper = v8::DataView::New(v8Buffer.As<v8::ArrayBuffe r>(), byteOffset(), byteLength());
35 35
36 return associateWithWrapper(isolate, wrapperTypeInfo, wrapper); 36 return associateWithWrapper(isolate, wrapperTypeInfo, wrapper);
37 } 37 }
38 38
39 v8::Local<v8::Object> DOMDataView::associateWithWrapper(v8::Isolate* isolate, co nst WrapperTypeInfo* wrapperTypeInfo, v8::Local<v8::Object> wrapper) 39 v8::Local<v8::Object> DOMDataView::associateWithWrapper(v8::Isolate* isolate, co nst WrapperTypeInfo* wrapperTypeInfo, v8::Local<v8::Object> wrapper)
40 { 40 {
41 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperTypeIn fo, wrapper); 41 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperTypeIn fo, wrapper);
42 } 42 }
43 43
44 } // namespace blink 44 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/DOMDataView.h ('k') | Source/core/dom/DOMTypedArray.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698