Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5623 matching lines...) Expand 10 before | Expand all | Expand 10 after
5634 5634
5635 styleEngine().platformColorsChanged(); 5635 styleEngine().platformColorsChanged();
5636 } 5636 }
5637 5637
5638 void Document::clearWeakMembers(Visitor* visitor) 5638 void Document::clearWeakMembers(Visitor* visitor)
5639 { 5639 {
5640 if (m_axObjectCache) 5640 if (m_axObjectCache)
5641 m_axObjectCache->clearWeakMembers(visitor); 5641 m_axObjectCache->clearWeakMembers(visitor);
5642 } 5642 }
5643 5643
5644 v8::Local<v8::Object> Document::wrap(v8::Local<v8::Object> creationContext, v8:: Isolate* isolate) 5644 v8::Local<v8::Object> Document::wrap(v8::Isolate* isolate, v8::Local<v8::Object> creationContext)
5645 { 5645 {
5646 // It's possible that no one except for the new wrapper owns this object at 5646 // It's possible that no one except for the new wrapper owns this object at
5647 // this moment, so we have to prevent GC to collect this object until the 5647 // this moment, so we have to prevent GC to collect this object until the
5648 // object gets associated with the wrapper. 5648 // object gets associated with the wrapper.
5649 RefPtrWillBeRawPtr<Document> protect(this); 5649 RefPtrWillBeRawPtr<Document> protect(this);
5650 5650
5651 ASSERT(!DOMDataStore::containsWrapper(this, isolate)); 5651 ASSERT(!DOMDataStore::containsWrapper(this, isolate));
5652 5652
5653 const WrapperTypeInfo* wrapperType = wrapperTypeInfo(); 5653 const WrapperTypeInfo* wrapperType = wrapperTypeInfo();
5654 5654
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
5774 #ifndef NDEBUG 5774 #ifndef NDEBUG
5775 using namespace blink; 5775 using namespace blink;
5776 void showLiveDocumentInstances() 5776 void showLiveDocumentInstances()
5777 { 5777 {
5778 WeakDocumentSet& set = liveDocumentSet(); 5778 WeakDocumentSet& set = liveDocumentSet();
5779 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5779 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5780 for (Document* document : set) 5780 for (Document* document : set)
5781 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5781 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5782 } 5782 }
5783 #endif 5783 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698