Source/core/dom/DOMDataView.h - Issue 1126013003: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMDataView.h

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/DOMDataView.h

diff --git a/Source/core/dom/DOMDataView.h b/Source/core/dom/DOMDataView.h

index 26a8e9b3274c270a19a96346aace99201d02691e..c081de1d7b01afc54cfffcd3380e4ea2c27dd46a 100644

--- a/Source/core/dom/DOMDataView.h

+++ b/Source/core/dom/DOMDataView.h

@@ -20,7 +20,7 @@ public:

const DataView* view() const { return static_cast<const DataView*>(DOMArrayBufferView::view()); }

DataView* view() { return static_cast<DataView*>(DOMArrayBufferView::view()); }

- virtual v8::Local<v8::Object> wrap(v8::Local<v8::Object> creationContext, v8::Isolate*) override;

+ virtual v8::Local<v8::Object> wrap(v8::Isolate*, v8::Local<v8::Object> creationContext) override;

virtual v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeInfo*, v8::Local<v8::Object> wrapper) override;

private:

« no previous file with comments | « Source/core/dom/DOMArrayBufferView.h ('k') | Source/core/dom/DOMDataView.cpp » ('j') | no next file with comments »