Source/bindings/core/v8/ScriptWrappable.cpp - Issue 1126013003: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptWrappable.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptWrappable.cpp

diff --git a/Source/bindings/core/v8/ScriptWrappable.cpp b/Source/bindings/core/v8/ScriptWrappable.cpp

index c708a8e0052c51d49ec3f9216ff342327c272ef0..a2607fb76152f26c46a5d19b31e2c91fa85c92f4 100644

--- a/Source/bindings/core/v8/ScriptWrappable.cpp

+++ b/Source/bindings/core/v8/ScriptWrappable.cpp

@@ -39,7 +39,7 @@ private:

} // namespace

-v8::Local<v8::Object> ScriptWrappable::wrap(v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

+v8::Local<v8::Object> ScriptWrappable::wrap(v8::Isolate* isolate, v8::Local<v8::Object> creationContext)

{

const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();

« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/bindings/core/v8/ToV8.h » ('j') | no next file with comments »