Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Side by Side Diff: Source/core/frame/DOMWindow.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/workers/WorkerGlobalScope.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/frame/DOMWindow.h" 6 #include "core/frame/DOMWindow.h"
7 7
8 #include "bindings/core/v8/ScriptCallStackFactory.h" 8 #include "bindings/core/v8/ScriptCallStackFactory.h"
9 #include "core/dom/Document.h" 9 #include "core/dom/Document.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
(...skipping 14 matching lines...) Expand all
25 25
26 DOMWindow::DOMWindow() 26 DOMWindow::DOMWindow()
27 : m_windowIsClosing(false) 27 : m_windowIsClosing(false)
28 { 28 {
29 } 29 }
30 30
31 DOMWindow::~DOMWindow() 31 DOMWindow::~DOMWindow()
32 { 32 {
33 } 33 }
34 34
35 v8::Local<v8::Object> DOMWindow::wrap(v8::Local<v8::Object> creationContext, v8: :Isolate*) 35 v8::Local<v8::Object> DOMWindow::wrap(v8::Isolate*, v8::Local<v8::Object> creati onContext)
36 { 36 {
37 // DOMWindow must never be wrapped with wrap method. The wrappers must be 37 // DOMWindow must never be wrapped with wrap method. The wrappers must be
38 // created at WindowProxy::installDOMWindow(). 38 // created at WindowProxy::installDOMWindow().
39 RELEASE_ASSERT_NOT_REACHED(); 39 RELEASE_ASSERT_NOT_REACHED();
40 return v8::Local<v8::Object>(); 40 return v8::Local<v8::Object>();
41 } 41 }
42 42
43 v8::Local<v8::Object> DOMWindow::associateWithWrapper(v8::Isolate*, const Wrappe rTypeInfo*, v8::Local<v8::Object> wrapper) 43 v8::Local<v8::Object> DOMWindow::associateWithWrapper(v8::Isolate*, const Wrappe rTypeInfo*, v8::Local<v8::Object> wrapper)
44 { 44 {
45 RELEASE_ASSERT_NOT_REACHED(); // same as wrap method 45 RELEASE_ASSERT_NOT_REACHED(); // same as wrap method
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 return message + "Protocols, domains, and ports must match."; 278 return message + "Protocols, domains, and ports must match.";
279 } 279 }
280 280
281 DEFINE_TRACE(DOMWindow) 281 DEFINE_TRACE(DOMWindow)
282 { 282 {
283 visitor->trace(m_location); 283 visitor->trace(m_location);
284 EventTargetWithInlineData::trace(visitor); 284 EventTargetWithInlineData::trace(visitor);
285 } 285 }
286 286
287 } // namespace blink 287 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | Source/core/workers/WorkerGlobalScope.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698