Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/core/v8/ToV8.h

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.cpp ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ToV8.h
diff --git a/Source/bindings/core/v8/ToV8.h b/Source/bindings/core/v8/ToV8.h
index 7643fe92f13bab72dc37130845367d4e83969334..a439192226ed32f9c8caf4cd1d831f1d66584ebd 100644
--- a/Source/bindings/core/v8/ToV8.h
+++ b/Source/bindings/core/v8/ToV8.h
@@ -34,7 +34,7 @@ inline v8::Local<v8::Value> toV8(ScriptWrappable* impl, v8::Local<v8::Object> cr
if (!wrapper.IsEmpty())
return wrapper;
- return impl->wrap(creationContext, isolate);
+ return impl->wrap(isolate, creationContext);
}
inline v8::Local<v8::Value> toV8(Node* impl, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
@@ -45,7 +45,7 @@ inline v8::Local<v8::Value> toV8(Node* impl, v8::Local<v8::Object> creationConte
if (!wrapper.IsEmpty())
return wrapper;
- return ScriptWrappable::fromNode(impl)->wrap(creationContext, isolate);
+ return ScriptWrappable::fromNode(impl)->wrap(isolate, creationContext);
}
// Special versions for DOMWindow, WorkerGlobalScope and EventTarget
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.cpp ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698