Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ToV8.h ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.h
diff --git a/Source/bindings/core/v8/V8Binding.h b/Source/bindings/core/v8/V8Binding.h
index 6a484ee2359c021922eb26d4a96f67834c4de107..755dbb30322c34d7904a19a7c98d812dfab0dff2 100644
--- a/Source/bindings/core/v8/V8Binding.h
+++ b/Source/bindings/core/v8/V8Binding.h
@@ -200,7 +200,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, ScriptWrappable*
}
if (DOMDataStore::setReturnValue(callbackInfo.GetReturnValue(), impl))
return;
- v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.GetIsolate(), callbackInfo.Holder());
v8SetReturnValue(callbackInfo, wrapper);
}
@@ -213,7 +213,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, Node* impl)
}
if (DOMDataStore::setReturnValue(callbackInfo.GetReturnValue(), impl))
return;
- v8::Local<v8::Object> wrapper = ScriptWrappable::fromNode(impl)->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Local<v8::Object> wrapper = ScriptWrappable::fromNode(impl)->wrap(callbackInfo.GetIsolate(), callbackInfo.Holder());
v8SetReturnValue(callbackInfo, wrapper);
}
@@ -259,7 +259,7 @@ inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, Scrip
}
if (DOMDataStore::setReturnValueForMainWorld(callbackInfo.GetReturnValue(), impl))
return;
- v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.GetIsolate(), callbackInfo.Holder());
v8SetReturnValue(callbackInfo, wrapper);
}
@@ -328,7 +328,7 @@ inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, ScriptWrappab
}
if (DOMDataStore::setReturnValueFast(callbackInfo.GetReturnValue(), impl, callbackInfo.Holder(), wrappable))
return;
- v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Local<v8::Object> wrapper = impl->wrap(callbackInfo.GetIsolate(), callbackInfo.Holder());
v8SetReturnValue(callbackInfo, wrapper);
}
@@ -341,7 +341,7 @@ inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, Node* impl, c
}
if (DOMDataStore::setReturnValueFast(callbackInfo.GetReturnValue(), impl, callbackInfo.Holder(), wrappable))
return;
- v8::Local<v8::Object> wrapper = ScriptWrappable::fromNode(impl)->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Local<v8::Object> wrapper = ScriptWrappable::fromNode(impl)->wrap(callbackInfo.GetIsolate(), callbackInfo.Holder());
v8SetReturnValue(callbackInfo, wrapper);
}
« no previous file with comments | « Source/bindings/core/v8/ToV8.h ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698