Source/core/dom/Node.cpp - Issue 1126013003: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 1126013003: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Wrap function Change for v8::Isolate* , as it is no more optional argument Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index c97d2148a0dc25192df067bb0e029c0f6be09477..68f4952d94db0fd71c93bf15324c0869c1cd1247 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -2461,7 +2461,7 @@ unsigned Node::lengthOfContents() const

return 0;

}

-v8::Local<v8::Object> Node::wrap(v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

+v8::Local<v8::Object> Node::wrap(v8::Isolate* isolate, v8::Local<v8::Object> creationContext)

{

// It's possible that no one except for the new wrapper owns this object at

// this moment, so we have to prevent GC to collect this object until the

« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/frame/DOMWindow.h » ('j') | no next file with comments »