Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106503003: Changed GL enums from GraphicsContext3D to standard versions (Take 2) (Closed)

Created:
7 years ago by bajones
Modified:
7 years ago
CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Changed GL enums from GraphicsContext3D to standard versions (Take 2) Updated all callers to use the standard GL enums. This is the first step in eventually removing our dependence on GraphicsContext3D's thin WebGraphicsContext3D wrapper. BUG=326382 TBR=kbr@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1088 lines, -1395 lines) Patch
M Source/core/html/canvas/OESVertexArrayObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.cpp View 4 chunks +24 lines, -24 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 16 chunks +72 lines, -70 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLProgram.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 155 chunks +704 lines, -703 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 6 chunks +39 lines, -39 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/Extensions3D.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/graphics/Extensions3D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.h View 2 chunks +2 lines, -314 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.cpp View 11 chunks +57 lines, -57 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3DImagePacking.cpp View 3 chunks +23 lines, -23 lines 0 comments Download
M Source/platform/graphics/GraphicsTypes3D.h View 2 chunks +10 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterCompiledProgram.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterGlobalContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterMesh.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/custom/CustomFilterRenderer.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/platform/graphics/filters/custom/FECustomFilter.cpp View 9 chunks +29 lines, -29 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 20 chunks +75 lines, -75 lines 0 comments Download
M Source/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/DrawingBufferTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/MockWebGraphicsContext3D.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bajones
Last CL had to be reverted due to Android issues. Taking care to explicitly call ...
7 years ago (2013-12-11 22:01:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/106503003/1
7 years ago (2013-12-11 22:41:34 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-12 00:10:49 UTC) #3
Message was sent while issue was closed. 
Change committed as 163735

Powered by Google App Engine
This is Rietveld 408576698