Source/platform/graphics/Extensions3D.cpp - Issue 106503003: Changed GL enums from GraphicsContext3D to standard versions (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/Extensions3D.cpp

Issue 106503003: Changed GL enums from GraphicsContext3D to standard versions (Take 2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/Extensions3D.cpp

diff --git a/Source/platform/graphics/Extensions3D.cpp b/Source/platform/graphics/Extensions3D.cpp

index 2a90872da4323d73c8450950390a6606aaab8cca..6d0a61e68644cee035810c9c6dc7746efa3ff30e 100644

--- a/Source/platform/graphics/Extensions3D.cpp

+++ b/Source/platform/graphics/Extensions3D.cpp

@@ -177,8 +177,8 @@ bool Extensions3D::canUseCopyTextureCHROMIUM(GC3Denum destFormat, GC3Denum destT

{

// FIXME: restriction of (RGB || RGBA)/UNSIGNED_BYTE/(Level 0) should be lifted when

// WebGraphicsContext3D::copyTextureCHROMIUM(...) are fully functional.

- if ((destFormat == GraphicsContext3D::RGB || destFormat == GraphicsContext3D::RGBA)

- && destType == GraphicsContext3D::UNSIGNED_BYTE

+ if ((destFormat == GL_RGB || destFormat == GL_RGBA)

+ && destType == GL_UNSIGNED_BYTE

&& !level)

return true;

return false;