Source/web/WebMediaPlayerClientImpl.cpp - Issue 106503003: Changed GL enums from GraphicsContext3D to standard versions (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 106503003: Changed GL enums from GraphicsContext3D to standard versions (Take 2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebMediaPlayerClientImpl.cpp

diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp

index c408886aaed594144f688b406ccaa10e7ab9fcbf..553aaac41cff00340509d5e1f5d1aa2289e37b1b 100644

--- a/Source/web/WebMediaPlayerClientImpl.cpp

+++ b/Source/web/WebMediaPlayerClientImpl.cpp

@@ -594,7 +594,7 @@ void WebMediaPlayerClientImpl::paintOnAndroid(WebCore::GraphicsContext* context,

WebGraphicsContext3D* webGraphicsContext3D = context3D->webContext();

WebCanvas* canvas = context->canvas();

unsigned textureId = static_cast<unsigned>((m_bitmap.getTexture())->getTextureHandle());

- if (!m_webMediaPlayer->copyVideoTextureToPlatformTexture(webGraphicsContext3D, textureId, 0, GraphicsContext3D::RGBA, GraphicsContext3D::UNSIGNED_BYTE, true, false))

+ if (!m_webMediaPlayer->copyVideoTextureToPlatformTexture(webGraphicsContext3D, textureId, 0, GL_RGBA, GL_UNSIGNED_BYTE, true, false))

return;

// Draw the texture based bitmap onto the Canvas. If the canvas is hardware based, this will do a GPU-GPU texture copy. If the canvas is software based,

« no previous file with comments | « Source/web/DEPS ('k') | Source/web/tests/DrawingBufferTest.cpp » ('j') | no next file with comments »