Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1061733002: Remove windows/mac/ios specific code from //ui (Closed)

Created:
5 years, 8 months ago by jamesr
Modified:
5 years, 8 months ago
Reviewers:
tonyg, Elliot Glaysher
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove windows/mac/ios specific code from //ui We aren't building for these platforms. Also removes gyp files since we don't use those. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/60709e15761fed40f08652fa7f1a373fa88645a3

Patch Set 1 #

Patch Set 2 : fix default try set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -8906 lines) Patch
D ui/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/BUILD.gn View 3 chunks +1 line, -57 lines 0 comments Download
D ui/base/DEPS View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +1 line, -5 lines 0 comments Download
D ui/display/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/display/chromeos/x11/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/display/types/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/display/util/x11/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/BUILD.gn View 5 chunks +4 lines, -7 lines 0 comments Download
D ui/events/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/events/PRESUBMIT.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
M ui/events/event.cc View 3 chunks +1 line, -28 lines 0 comments Download
M ui/events/event_unittest.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/events/gestures/gesture_recognizer_impl_mac.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/events/keycodes/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/events/keycodes/dom4/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/keycodes/dom4/keycode_converter.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ui/events/keycodes/dom4/keycode_converter_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/events/platform/platform_event_builder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/platform/platform_event_builder_x_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/events/platform/platform_event_utils.h View 2 chunks +0 lines, -16 lines 0 comments Download
D ui/events/test/cocoa_test_event_utils.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/events/test/cocoa_test_event_utils.mm View 1 chunk +0 lines, -135 lines 0 comments Download
M ui/gfx/BUILD.gn View 8 chunks +28 lines, -82 lines 0 comments Download
D ui/gfx/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/gfx/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/animation/animation.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/gfx/animation/animation_unittest.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/gfx/animation/tween.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/animation/tween_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D ui/gfx/codec/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/display.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/gfx/frame_time.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/geometry/point.h View 2 chunks +0 lines, -25 lines 0 comments Download
M ui/gfx/geometry/point.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M ui/gfx/geometry/rect.h View 2 chunks +0 lines, -22 lines 0 comments Download
M ui/gfx/geometry/rect.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/gfx/geometry/rect_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M ui/gfx/geometry/size.h View 2 chunks +0 lines, -24 lines 0 comments Download
M ui/gfx/geometry/size.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/native_widget_types.h View 5 chunks +6 lines, -92 lines 0 comments Download
D ui/gfx/test/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/gfx/test/run_all_unittests.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D ui/gfx/test/ui_cocoa_test_helper.h View 1 chunk +0 lines, -149 lines 0 comments Download
D ui/gfx/test/ui_cocoa_test_helper.mm View 1 chunk +0 lines, -221 lines 0 comments Download
D ui/gfx/win/hwnd_util.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/gfx/win/hwnd_util.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D ui/gfx/win/msg_util.h View 1 chunk +0 lines, -2283 lines 0 comments Download
D ui/gfx/win/scoped_set_map_mode.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/gfx/win/singleton_hwnd.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/gfx/win/singleton_hwnd.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/gfx/win/window_impl.h View 1 chunk +0 lines, -124 lines 0 comments Download
D ui/gfx/win/window_impl.cc View 1 chunk +0 lines, -312 lines 0 comments Download
M ui/gl/BUILD.gn View 6 chunks +12 lines, -52 lines 0 comments Download
D ui/gl/DEPS View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gl/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/gl/gl.gyp View 1 chunk +0 lines, -323 lines 0 comments Download
M ui/gl/gl_bindings.h View 6 chunks +3 lines, -38 lines 0 comments Download
M ui/gl/gl_bindings.cc View 3 chunks +3 lines, -24 lines 0 comments Download
D ui/gl/gl_bindings_api_autogen_wgl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/gl/gl_bindings_autogen_wgl.h View 1 chunk +0 lines, -147 lines 0 comments Download
D ui/gl/gl_bindings_autogen_wgl.cc View 1 chunk +0 lines, -575 lines 0 comments Download
D ui/gl/gl_context_cgl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/gl/gl_context_cgl.cc View 1 chunk +0 lines, -314 lines 0 comments Download
D ui/gl/gl_context_mac.mm View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/gl/gl_context_wgl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/gl/gl_context_wgl.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D ui/gl/gl_context_win.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M ui/gl/gl_fence.cc View 3 chunks +0 lines, -13 lines 0 comments Download
D ui/gl/gl_fence_apple.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/gl/gl_fence_apple.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gl/gl_image_io_surface.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/gl/gl_image_io_surface.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M ui/gl/gl_image_memory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 6 chunks +3 lines, -21 lines 0 comments Download
M ui/gl/gl_implementation.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_implementation.cc View 2 chunks +1 line, -9 lines 0 comments Download
D ui/gl/gl_implementation_mac.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D ui/gl/gl_implementation_win.cc View 1 chunk +0 lines, -402 lines 0 comments Download
M ui/gl/gl_share_group.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/gl/gl_share_group.cc View 2 chunks +1 line, -16 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 3 chunks +0 lines, -18 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +0 lines, -116 lines 0 comments Download
D ui/gl/gl_surface_mac.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D ui/gl/gl_surface_wgl.h View 1 chunk +0 lines, -76 lines 0 comments Download
D ui/gl/gl_surface_wgl.cc View 1 chunk +0 lines, -361 lines 0 comments Download
D ui/gl/gl_surface_win.cc View 1 chunk +0 lines, -351 lines 0 comments Download
D ui/gl/gl_wgl_api_implementation.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ui/gl/gl_wgl_api_implementation.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M ui/gl/gpu_switching_manager.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/gl/gpu_switching_manager.cc View 5 chunks +1 line, -51 lines 0 comments Download
D ui/gl/scoped_cgl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gl/scoped_cgl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/platform_window/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/platform_window/platform_window.h View 1 chunk +1 line, -9 lines 0 comments Download
D ui/platform_window/win/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/platform_window/win/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/platform_window/win/win_window.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/platform_window/win/win_window.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D ui/platform_window/win/win_window_export.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/platform_window/x11/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jamesr
Only -8.9k but still helpful
5 years, 8 months ago (2015-04-03 23:46:18 UTC) #2
jamesr
5 years, 8 months ago (2015-04-03 23:46:53 UTC) #4
tonyg
lgtm
5 years, 8 months ago (2015-04-03 23:48:30 UTC) #5
jamesr
5 years, 8 months ago (2015-04-03 23:59:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
60709e15761fed40f08652fa7f1a373fa88645a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698