Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed)

Created:
7 years ago by sky
Modified:
7 years ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, ben+aura_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, haitaol+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, ben+views_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, rsimha+watch_chromium.org, tfarina, ben+ash_chromium.org, James Su, ben+corewm_chromium.org
Visibility:
Public.

Description

Changes MouseEvent constructor to take changed_button_flags. I want this for EventGenerator, but it seems best to make everyone think about this rather than create another constructor. BUG=none TEST=none R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241358

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : fix windows side #

Total comments: 2

Patch Set 4 : fix rootwindowunittest #

Patch Set 5 : fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -180 lines) Patch
M ash/autoclick/autoclick_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 5 chunks +5 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/sticky_keys_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 10 chunks +14 lines, -11 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/new_avatar_menu_button_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/reload_button_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 3 19 chunks +26 lines, -19 lines 0 comments Download
M ui/aura/test/event_generator.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/window_targeter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/event.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/events/event_dispatcher_unittest.cc View 7 chunks +10 lines, -7 lines 0 comments Download
M ui/events/event_processor_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/events/event_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/views/message_popup_collection_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/combobox_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/single_split_view_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/slider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 10 chunks +24 lines, -19 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/compound_event_filter_unittest.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 3 15 chunks +18 lines, -16 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 9 chunks +16 lines, -12 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 9 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
7 years ago (2013-12-16 21:45:29 UTC) #1
sadrul
https://codereview.chromium.org/101573006/diff/40001/ui/events/event.cc File ui/events/event.cc (right): https://codereview.chromium.org/101573006/diff/40001/ui/events/event.cc#newcode285 ui/events/event.cc:285: int changed_button_flags) Is this something we could auto-compute with ...
7 years ago (2013-12-17 04:23:49 UTC) #2
sky
https://codereview.chromium.org/101573006/diff/40001/ui/events/event.cc File ui/events/event.cc (right): https://codereview.chromium.org/101573006/diff/40001/ui/events/event.cc#newcode285 ui/events/event.cc:285: int changed_button_flags) On 2013/12/17 04:23:49, sadrul wrote: > Is ...
7 years ago (2013-12-17 15:28:44 UTC) #3
sadrul
LGTM
7 years ago (2013-12-17 15:53:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/101573006/40001
7 years ago (2013-12-17 16:00:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-17 16:42:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/101573006/60001
7 years ago (2013-12-17 16:59:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/101573006/60001
7 years ago (2013-12-17 18:28:49 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years ago (2013-12-17 18:52:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/101573006/70001
7 years ago (2013-12-17 18:53:01 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-17 21:20:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 241358

Powered by Google App Engine
This is Rietveld 408576698