ui/views/controls/button/custom_button.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/custom_button.cc

diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc

index 2be2a2301e1dce9755e7dac8820baab0b05ef33e..cafa5a30c50b439c6d9067617dfadeb386de7891 100644

--- a/ui/views/controls/button/custom_button.cc

+++ b/ui/views/controls/button/custom_button.cc

@@ -199,6 +199,7 @@ bool CustomButton::OnKeyPressed(const ui::KeyEvent& event) {

ui::MouseEvent synthetic_event(ui::ET_MOUSE_RELEASED,

gfx::Point(),

+ ui::EF_LEFT_MOUSE_BUTTON,

ui::EF_LEFT_MOUSE_BUTTON);

NotifyClick(synthetic_event);

} else {

@@ -216,6 +217,7 @@ bool CustomButton::OnKeyReleased(const ui::KeyEvent& event) {

ui::MouseEvent synthetic_event(ui::ET_MOUSE_RELEASED,

gfx::Point(),

+ ui::EF_LEFT_MOUSE_BUTTON,

ui::EF_LEFT_MOUSE_BUTTON);

NotifyClick(synthetic_event);

return true;

@@ -260,6 +262,7 @@ bool CustomButton::AcceleratorPressed(const ui::Accelerator& accelerator) {

ui::MouseEvent synthetic_event(ui::ET_MOUSE_RELEASED,

gfx::Point(),

+ ui::EF_LEFT_MOUSE_BUTTON,

ui::EF_LEFT_MOUSE_BUTTON);

NotifyClick(synthetic_event);

return true;