ash/shelf/shelf_tooltip_manager_unittest.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_tooltip_manager_unittest.cc

diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc

index 33792ec4c8d45dc5720b37e838cdcc4fa2fe10a5..6114202c9f6b8412aea1bd6952c4c9a269f673ee 100644

--- a/ash/shelf/shelf_tooltip_manager_unittest.cc

+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc

@@ -231,7 +231,8 @@ TEST_F(ShelfTooltipManagerTest, HideForMouseMoveEvent) {

// Shouldn't hide if the mouse is in the tooltip.

ui::MouseEvent mouse_event(ui::ET_MOUSE_MOVED, tooltip_rect.CenterPoint(),

- tooltip_rect.CenterPoint(), ui::EF_NONE);

+ tooltip_rect.CenterPoint(), ui::EF_NONE,

+ ui::EF_NONE);

ui::LocatedEventTestApi test_api(&mouse_event);

SetEventTarget(root_window, &mouse_event);

@@ -260,7 +261,8 @@ TEST_F(ShelfTooltipManagerTest, HideForMouseClickEvent) {

// Should hide if the mouse is pressed in the tooltip.

ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, tooltip_rect.CenterPoint(),

- tooltip_rect.CenterPoint(), ui::EF_NONE);

+ tooltip_rect.CenterPoint(), ui::EF_NONE,

+ ui::EF_NONE);

SetEventTarget(root_window, &mouse_event);

event_handler->OnMouseEvent(&mouse_event);

« no previous file with comments | « ash/extended_desktop_unittest.cc ('k') | ash/shelf/shelf_view.cc » ('j') | no next file with comments »