ash/shelf/shelf_view.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_view.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_view.cc

diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc

index 3b7e204a8775683affa02522ee3426ffb2e8362d..101c0cd65298afc8b266fb26317857b399e58491 100644

--- a/ash/shelf/shelf_view.cc

+++ b/ash/shelf/shelf_view.cc

@@ -616,7 +616,7 @@ bool ShelfView::StartDrag(const std::string& app_id,

ash::wm::ConvertPointFromScreen(

ash::wm::GetRootWindowAt(location_in_screen_coordinates),

&point_in_root);

- ui::MouseEvent event(ui::ET_MOUSE_PRESSED, pt, point_in_root, 0);

+ ui::MouseEvent event(ui::ET_MOUSE_PRESSED, pt, point_in_root, 0, 0);

PointerPressedOnButton(drag_and_drop_view,

ShelfButtonHost::DRAG_AND_DROP,

event);

@@ -639,7 +639,7 @@ bool ShelfView::Drag(const gfx::Point& location_in_screen_coordinates) {

ash::wm::ConvertPointFromScreen(

ash::wm::GetRootWindowAt(location_in_screen_coordinates),

&point_in_root);

- ui::MouseEvent event(ui::ET_MOUSE_DRAGGED, pt, point_in_root, 0);

+ ui::MouseEvent event(ui::ET_MOUSE_DRAGGED, pt, point_in_root, 0, 0);

PointerDraggedOnButton(drag_and_drop_view,

ShelfButtonHost::DRAG_AND_DROP,

event);

« no previous file with comments | « ash/shelf/shelf_tooltip_manager_unittest.cc ('k') | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »