ash/wm/workspace/workspace_event_handler_unittest.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_event_handler_unittest.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_event_handler_unittest.cc

diff --git a/ash/wm/workspace/workspace_event_handler_unittest.cc b/ash/wm/workspace/workspace_event_handler_unittest.cc

index feec4bdbc6b3d4037d12aaadf9a8be8129cf4de4..b42c85135955755435a96d2ced906352f728a43f 100644

--- a/ash/wm/workspace/workspace_event_handler_unittest.cc

+++ b/ash/wm/workspace/workspace_event_handler_unittest.cc

@@ -271,12 +271,14 @@ TEST_F(WorkspaceEventHandlerTest, DoubleClickCaptionTogglesMaximize) {

WindowPropertyObserver observer(window.get());

ui::MouseEvent press(ui::ET_MOUSE_PRESSED, generator.current_location(),

generator.current_location(),

- ui::EF_MIDDLE_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK);

+ ui::EF_MIDDLE_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK,

+ ui::EF_MIDDLE_MOUSE_BUTTON);

aura::WindowEventDispatcher* dispatcher = root->GetDispatcher();

dispatcher->AsRootWindowHostDelegate()->OnHostMouseEvent(&press);

ui::MouseEvent release(ui::ET_MOUSE_RELEASED, generator.current_location(),

generator.current_location(),

- ui::EF_IS_DOUBLE_CLICK);

+ ui::EF_IS_DOUBLE_CLICK,

+ ui::EF_MIDDLE_MOUSE_BUTTON);

dispatcher->AsRootWindowHostDelegate()->OnHostMouseEvent(&release);

EXPECT_FALSE(window_state->IsMaximized());