ui/aura/remote_root_window_host_win.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/remote_root_window_host_win.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/remote_root_window_host_win.cc

diff --git a/ui/aura/remote_root_window_host_win.cc b/ui/aura/remote_root_window_host_win.cc

index 760d95525bff8834f7e474b75fbcc0b03e087d52..db66beb41d475d46bafad6198b5bce2500f78710 100644

--- a/ui/aura/remote_root_window_host_win.cc

+++ b/ui/aura/remote_root_window_host_win.cc

@@ -487,7 +487,7 @@ void RemoteRootWindowHostWin::OnMouseMoved(int32 x, int32 y, int32 flags) {

return;

gfx::Point location(x, y);

- ui::MouseEvent event(ui::ET_MOUSE_MOVED, location, location, flags);

+ ui::MouseEvent event(ui::ET_MOUSE_MOVED, location, location, flags, 0);

delegate_->OnHostMouseEvent(&event);

}

@@ -498,7 +498,8 @@ void RemoteRootWindowHostWin::OnMouseButton(

ui::EventType type,

ui::EventFlags flags) {

gfx::Point location(x, y);

- ui::MouseEvent mouse_event(type, location, location, flags);

+ // TODO: this needs to pass in changed flags.

+ ui::MouseEvent mouse_event(type, location, location, flags, 0);

SetEventFlags(flags | key_event_flags());

if (type == ui::ET_MOUSEWHEEL) {

« no previous file with comments | « ui/app_list/views/apps_grid_view_unittest.cc ('k') | ui/aura/root_window.cc » ('j') | no next file with comments »