content/browser/renderer_host/input/synthetic_gesture_target_aura.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/synthetic_gesture_target_aura.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/reload_button_unittest.cc ('k') | content/browser/web_contents/aura/window_slider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/synthetic_gesture_target_aura.cc

diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc b/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc

index f9ab85895c7afc2d28b38ca25224e16a62cd00ff..facbede3840f69d9b254bb04ee62a24bb08c2e75 100644

--- a/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc

+++ b/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc

@@ -63,7 +63,7 @@ void SyntheticGestureTargetAura::DispatchWebMouseWheelEventToPlatform(

const ui::LatencyInfo&) {

gfx::Point location(web_wheel.x, web_wheel.y);

ui::MouseEvent mouse_event(

- ui::ET_MOUSEWHEEL, location, location, ui::EF_NONE);

+ ui::ET_MOUSEWHEEL, location, location, ui::EF_NONE, ui::EF_NONE);

ui::MouseWheelEvent wheel_event(

mouse_event, web_wheel.deltaX, web_wheel.deltaY);

@@ -127,7 +127,8 @@ void SyntheticGestureTargetAura::DispatchWebMouseEventToPlatform(

gfx::Point location(web_mouse.x, web_mouse.y);

ui::EventType event_type = WebMouseEventTypeToEventType(web_mouse.type);

int flags = WebMouseEventButtonToFlags(web_mouse.button);

- ui::MouseEvent mouse_event(event_type, location, location, flags);

+ // TODO: last argument (changed_button_flags) likely isn't right.

+ ui::MouseEvent mouse_event(event_type, location, location, flags, 0);

GetRootWindowHostDelegate()->OnHostMouseEvent(&mouse_event);

}