chrome/browser/ui/views/location_bar/star_view_browsertest.cc - Issue 101573006: Changes MouseEvent constructor to take changed_button_flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view_browsertest.cc

Issue 101573006: Changes MouseEvent constructor to take changed_button_flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test; needs updated expectations as mouse entered wasnt sent before because of env::mouse_butto… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/star_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

index d09a32f4f2ab93e413f3e1b1c30b6c2423c2f494..d85c5a38d5b558fcdebf1b544ec8e0c834ba9b25 100644

--- a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

@@ -43,9 +43,11 @@ IN_PROC_BROWSER_TEST_F(StarViewTest, MAYBE_HideOnSecondClick) {

browser_view->GetToolbarView()->location_bar()->star_view();

ui::MouseEvent pressed_event(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),

- ui::EF_LEFT_MOUSE_BUTTON);

+ ui::EF_LEFT_MOUSE_BUTTON,

+ ui::EF_LEFT_MOUSE_BUTTON);

ui::MouseEvent released_event(ui::ET_MOUSE_RELEASED, gfx::Point(),

- gfx::Point(), ui::EF_LEFT_MOUSE_BUTTON);

+ gfx::Point(), ui::EF_LEFT_MOUSE_BUTTON,

+ ui::EF_LEFT_MOUSE_BUTTON);

// Verify that clicking once shows the bookmark bubble.

EXPECT_FALSE(BookmarkBubbleView::IsShowing());