Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 326913002: Make dart2js unittests async. (Closed)

Created:
6 years, 6 months ago by Johnni Winther
Modified:
6 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3814 lines, -3451 lines) Patch
M tests/compiler/dart2js/arithmetic_simplification_test.dart View 2 chunks +13 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/array_static_intercept_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/boolified_operator_test.dart View 2 chunks +30 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/boolify_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/builtin_equals_test.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/builtin_interceptor_test.dart View 2 chunks +14 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/closure_codegen_test.dart View 2 chunks +24 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/code_motion_test.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 4 chunks +70 lines, -61 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 2 chunks +15 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/constant_folding_test.dart View 2 chunks +29 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/constant_namer_test.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +15 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/dead_phi_eliminator_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/declare_once_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/for_in_test.dart View 2 chunks +11 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/generate_at_use_site_test.dart View 2 chunks +14 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/gvn_test.dart View 2 chunks +40 lines, -31 lines 0 comments Download
M tests/compiler/dart2js/identity_test.dart View 2 chunks +12 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/interceptor_test.dart View 2 chunks +22 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/interpolation_folding_test.dart View 2 chunks +18 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/inverse_operator_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/is_inference2_test.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/is_inference_test.dart View 2 chunks +19 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/js_parser_statements_test.dart View 2 chunks +105 lines, -98 lines 0 comments Download
M tests/compiler/dart2js/js_parser_test.dart View 1 chunk +178 lines, -173 lines 0 comments Download
M tests/compiler/dart2js/licm_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/literal_list_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/literal_map_test.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/logical_expression_test.dart View 2 chunks +22 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/loop_test.dart View 2 chunks +17 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/minify_many_locals_test.dart View 2 chunks +21 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/mirror_system_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +31 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/null_type_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/override_inheritance_test.dart View 1 chunk +1409 lines, -1384 lines 0 comments Download
M tests/compiler/dart2js/part_of_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/pretty_parameter_test.dart View 2 chunks +28 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/private_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/redundant_phi_eliminator_test.dart View 2 chunks +15 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/reexport_handled_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 4 chunks +790 lines, -717 lines 0 comments Download
M tests/compiler/dart2js/simple_function_subtype_test.dart View 2 chunks +12 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/size_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/ssa_phi_codegen_test.dart View 2 chunks +16 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/strength_eq_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/string_escapes_test.dart View 1 chunk +15 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/switch_empty_default_test.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 34 chunks +501 lines, -439 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +57 lines, -55 lines 0 comments Download
M tests/compiler/dart2js/type_guard_unuser_test.dart View 2 chunks +30 lines, -25 lines 0 comments Download
M tests/compiler/dart2js/type_inference2_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference3_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_inference4_test.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_inference5_test.dart View 2 chunks +15 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 2 chunks +12 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 2 chunks +47 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
6 years, 6 months ago (2014-06-10 11:43:54 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/326913002/diff/1/tests/compiler/dart2js/exit_code_test.dart File tests/compiler/dart2js/exit_code_test.dart (right): https://codereview.chromium.org/326913002/diff/1/tests/compiler/dart2js/exit_code_test.dart#newcode51 tests/compiler/dart2js/exit_code_test.dart:51: /*Future scanBuiltinLibraries() { Remove the code?
6 years, 6 months ago (2014-06-10 12:32:54 UTC) #2
Johnni Winther
6 years, 6 months ago (2014-06-10 13:06:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r37178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698