Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tests/compiler/dart2js/redundant_phi_eliminator_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/private_test.dart ('k') | tests/compiler/dart2js/reexport_handled_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/redundant_phi_eliminator_test.dart
diff --git a/tests/compiler/dart2js/redundant_phi_eliminator_test.dart b/tests/compiler/dart2js/redundant_phi_eliminator_test.dart
index de35f7e9d1463ba764ea3dba569b1fb00e5c16b3..d7f2b72419281c0d2a286270a077ba035e6b4cc7 100644
--- a/tests/compiler/dart2js/redundant_phi_eliminator_test.dart
+++ b/tests/compiler/dart2js/redundant_phi_eliminator_test.dart
@@ -2,7 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_ONE = r"""
@@ -28,13 +30,17 @@ void foo() {
""";
main() {
- String generated = compile(TEST_ONE, entry: 'foo');
- RegExp regexp = new RegExp("toBeRemoved");
- Expect.isTrue(!regexp.hasMatch(generated));
+ asyncTest(() => Future.wait([
+ compile(TEST_ONE, entry: 'foo', check: (String generated) {
+ RegExp regexp = new RegExp("toBeRemoved");
+ Expect.isTrue(!regexp.hasMatch(generated));
+ }),
- generated = compile(TEST_TWO, entry: 'foo');
- regexp = new RegExp("toBeRemoved");
- Expect.isTrue(!regexp.hasMatch(generated));
- regexp = new RegExp("temp");
- Expect.isTrue(!regexp.hasMatch(generated));
+ compile(TEST_TWO, entry: 'foo', check: (String generated) {
+ RegExp regexp = new RegExp("toBeRemoved");
+ Expect.isTrue(!regexp.hasMatch(generated));
+ regexp = new RegExp("temp");
+ Expect.isTrue(!regexp.hasMatch(generated));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/private_test.dart ('k') | tests/compiler/dart2js/reexport_handled_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698