Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tests/compiler/dart2js/declare_once_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/dead_phi_eliminator_test.dart ('k') | tests/compiler/dart2js/find_my_name_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/declare_once_test.dart
diff --git a/tests/compiler/dart2js/declare_once_test.dart b/tests/compiler/dart2js/declare_once_test.dart
index 01fb13e373a5e1a29a9c77b6f44a9004a1c4a713..729a5abebcc2212e1a930cfff67f774013642f83 100644
--- a/tests/compiler/dart2js/declare_once_test.dart
+++ b/tests/compiler/dart2js/declare_once_test.dart
@@ -3,23 +3,25 @@
// BSD-style license that can be found in the LICENSE file.
// Test that parameters keep their names in the output.
-import "package:expect/expect.dart";
+import 'package:async_helper/async_helper.dart';
+import 'package:expect/expect.dart';
import 'compiler_helper.dart';
main() {
// For a function with only one variable we declare it inline for more
// compactness. Test that we don't also declare it at the start of the
// method.
- var generated = compile(
+ asyncTest(() => compile(
'final List a = const ["bar", "baz"];'
'int foo() {'
' for (int i = 0; i < a.length; i++) {'
' print(a[i]);'
' }'
'}',
- entry: 'foo', minify: false);
- RegExp re = new RegExp(r"var ");
- Expect.isTrue(re.hasMatch(generated));
- print(generated);
- Expect.equals(1, re.allMatches(generated).length);
+ entry: 'foo', minify: false).then((String generated) {
+ RegExp re = new RegExp(r"var ");
+ Expect.isTrue(re.hasMatch(generated));
+ print(generated);
+ Expect.equals(1, re.allMatches(generated).length);
+ }));
}
« no previous file with comments | « tests/compiler/dart2js/dead_phi_eliminator_test.dart ('k') | tests/compiler/dart2js/find_my_name_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698