Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tests/compiler/dart2js/boolified_operator_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/array_static_intercept_test.dart ('k') | tests/compiler/dart2js/boolify_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/boolified_operator_test.dart
diff --git a/tests/compiler/dart2js/boolified_operator_test.dart b/tests/compiler/dart2js/boolified_operator_test.dart
index 5ec4c83d3b4b08adca817216da8a9f8f9f3aca92..6a8bd9fdf60abd006e599fa39b654f66616e3c82 100644
--- a/tests/compiler/dart2js/boolified_operator_test.dart
+++ b/tests/compiler/dart2js/boolified_operator_test.dart
@@ -3,7 +3,10 @@
// BSD-style license that can be found in the LICENSE file.
library boolified_operator_test;
-import "package:expect/expect.dart";
+
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_EQUAL = r"""
@@ -50,27 +53,30 @@ foo(param0, param1) {
main() {
RegExp regexp = new RegExp('=== true');
- String generated = compile(TEST_EQUAL, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('eqB'));
-
- generated = compile(TEST_EQUAL_NULL, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('== null'));
-
- generated = compile(TEST_LESS, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('ltB'));
-
- generated = compile(TEST_LESS_EQUAL, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('leB'));
-
- generated = compile(TEST_GREATER, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('gtB'));
-
- generated = compile(TEST_GREATER_EQUAL, entry: 'foo');
- Expect.isFalse(generated.contains('=== true'));
- Expect.isTrue(generated.contains('geB'));
+ asyncTest(() => Future.wait([
+ compile(TEST_EQUAL, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('eqB'));
+ }),
+ compile(TEST_EQUAL_NULL, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('== null'));
+ }),
+ compile(TEST_LESS, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('ltB'));
+ }),
+ compile(TEST_LESS_EQUAL, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('leB'));
+ }),
+ compile(TEST_GREATER, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('gtB'));
+ }),
+ compile(TEST_GREATER_EQUAL, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('geB'));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/array_static_intercept_test.dart ('k') | tests/compiler/dart2js/boolify_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698