Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1930)

Unified Diff: tests/compiler/dart2js/generate_at_use_site_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/for_in_test.dart ('k') | tests/compiler/dart2js/gvn_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/generate_at_use_site_test.dart
diff --git a/tests/compiler/dart2js/generate_at_use_site_test.dart b/tests/compiler/dart2js/generate_at_use_site_test.dart
index 573b3027597bad88c0f75926fc1a9c84a4a7d34f..4e9e1004e878e0b1c0caba34c24f79ff5e6ee9c3 100644
--- a/tests/compiler/dart2js/generate_at_use_site_test.dart
+++ b/tests/compiler/dart2js/generate_at_use_site_test.dart
@@ -2,7 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String FIB = r"""
@@ -49,16 +51,17 @@ foo(a) {
""";
main() {
- // Make sure we don't introduce a new variable.
- RegExp regexp = new RegExp("var $anyIdentifier =");
- compileAndDoNotMatch(FIB, 'fib', regexp);
+ asyncTest(() => Future.wait([
+ // Make sure we don't introduce a new variable.
+ compileAndDoNotMatch(FIB, 'fib', new RegExp("var $anyIdentifier =")),
- regexp = new RegExp("isLeaf");
- compileAndDoNotMatch(BAR, 'bar', regexp);
+ compileAndDoNotMatch(BAR, 'bar', new RegExp("isLeaf")),
- String generated = compile(TEST, entry: 'foo');
- Expect.isFalse(generated.contains('else'));
- // Regression check to ensure that there is no floating variable
- // expression.
- Expect.isFalse(new RegExp('^[ ]*a;').hasMatch(generated));
+ compile(TEST, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains('else'));
+ // Regression check to ensure that there is no floating variable
+ // expression.
+ Expect.isFalse(new RegExp('^[ ]*a;').hasMatch(generated));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/for_in_test.dart ('k') | tests/compiler/dart2js/gvn_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698