Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: tests/compiler/dart2js/is_inference_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/is_inference_test.dart
diff --git a/tests/compiler/dart2js/is_inference_test.dart b/tests/compiler/dart2js/is_inference_test.dart
index d648913060716898da91137a57c44539b9836296..6f0a3b89bd7ea47fb1458e1f8a2cf3dcca7887c0 100644
--- a/tests/compiler/dart2js/is_inference_test.dart
+++ b/tests/compiler/dart2js/is_inference_test.dart
@@ -2,7 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_IF = r"""
@@ -69,20 +71,23 @@ test(param) {
}
""";
-compileAndTest(String code) {
- String generated = compile(code, entry: 'test');
- RegExp validAdd =
- new RegExp("($anyIdentifier \\+ 42)|($anyIdentifier \\+= 42)");
- RegExp invalidAdd = new RegExp("$anyIdentifier \\+ 53");
- Expect.isTrue(validAdd.hasMatch(generated));
- Expect.isFalse(invalidAdd.hasMatch(generated));
+Future compileAndTest(String code) {
+ return compile(code, entry: 'test', check: (String generated) {
+ RegExp validAdd =
+ new RegExp("($anyIdentifier \\+ 42)|($anyIdentifier \\+= 42)");
+ RegExp invalidAdd = new RegExp("$anyIdentifier \\+ 53");
+ Expect.isTrue(validAdd.hasMatch(generated));
+ Expect.isFalse(invalidAdd.hasMatch(generated));
+ });
}
main() {
- compileAndTest(TEST_IF);
- compileAndTest(TEST_IF_ELSE);
- compileAndTest(TEST_IF_RETURN);
- compileAndTest(TEST_IF_NOT_ELSE);
- compileAndTest(TEST_IF_NOT_RETURN);
- compileAndTest(TEST_IF_NOT_ELSE_RETURN);
+ asyncTest(() => Future.wait([
+ compileAndTest(TEST_IF),
+ compileAndTest(TEST_IF_ELSE),
+ compileAndTest(TEST_IF_RETURN),
+ compileAndTest(TEST_IF_NOT_ELSE),
+ compileAndTest(TEST_IF_NOT_RETURN),
+ compileAndTest(TEST_IF_NOT_ELSE_RETURN),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/is_inference2_test.dart ('k') | tests/compiler/dart2js/js_parser_statements_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698