Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: tests/compiler/dart2js/interceptor_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/identity_test.dart ('k') | tests/compiler/dart2js/interpolation_folding_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/interceptor_test.dart
diff --git a/tests/compiler/dart2js/interceptor_test.dart b/tests/compiler/dart2js/interceptor_test.dart
index 53a3ef5b9c23370e5b6cccacb4174c084018fe84..619d01896028ebcff7141ca520fccfa3794e15ea 100644
--- a/tests/compiler/dart2js/interceptor_test.dart
+++ b/tests/compiler/dart2js/interceptor_test.dart
@@ -2,7 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_ONE = r"""
@@ -24,18 +26,23 @@ const String TEST_TWO = r"""
""";
main() {
- // Check that one-shot interceptors preserve variable names, see
- // https://code.google.com/p/dart/issues/detail?id=8106.
- String generated = compile(TEST_ONE, entry: 'foo');
- Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.toString\$0\(a\)')));
- Expect.isTrue(generated.contains('myVariableName'));
-
- // Check that an intercepted getter that does not need to be
- // intercepted, is turned into a regular getter call or field
- // access.
- generated = compile(TEST_TWO, entry: 'foo');
- Expect.isFalse(generated.contains(r'a.get$length()'));
- Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.A\$\(\)\.length')));
- Expect.isTrue(
- generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as\(a\)')));
+ asyncTest(() => Future.wait([
+ // Check that one-shot interceptors preserve variable names, see
+ // https://code.google.com/p/dart/issues/detail?id=8106.
+ compile(TEST_ONE, entry: 'foo', check: (String generated) {
+ Expect.isTrue(
+ generated.contains(new RegExp(r'[$A-Z]+\.toString\$0\(a\)')));
+ Expect.isTrue(generated.contains('myVariableName'));
+ }),
+ // Check that an intercepted getter that does not need to be
+ // intercepted, is turned into a regular getter call or field
+ // access.
+ compile(TEST_TWO, entry: 'foo', check: (String generated) {
+ Expect.isFalse(generated.contains(r'a.get$length()'));
+ Expect.isTrue(
+ generated.contains(new RegExp(r'[$A-Z]+\.A\$\(\)\.length')));
+ Expect.isTrue(
+ generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as\(a\)')));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/identity_test.dart ('k') | tests/compiler/dart2js/interpolation_folding_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698