Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: tests/compiler/dart2js/loop_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/loop_test.dart
diff --git a/tests/compiler/dart2js/loop_test.dart b/tests/compiler/dart2js/loop_test.dart
index 9be71951198283a778582f65dbf9d392ebcf7bbd..fbb092ac7f9c3bd56b9ed22e82a9779de7225da1 100644
--- a/tests/compiler/dart2js/loop_test.dart
+++ b/tests/compiler/dart2js/loop_test.dart
@@ -2,7 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_ONE = r"""
@@ -52,12 +54,18 @@ foo(a) {
""";
main() {
- String generated = compile(TEST_ONE, entry: 'foo');
- Expect.isTrue(generated.contains(r'for ('));
- generated = compile(TEST_TWO, entry: 'foo');
- Expect.isTrue(!generated.contains(r'break'));
- generated = compile(TEST_THREE, entry: 'foo');
- Expect.isTrue(generated.contains(r'continue'));
- generated = compile(TEST_FOUR, entry: 'foo');
- Expect.isTrue(generated.contains(r'continue'));
+ asyncTest(() => Future.wait([
+ compile(TEST_ONE, entry: 'foo', check: (String generated) {
+ Expect.isTrue(generated.contains(r'for ('));
+ }),
+ compile(TEST_TWO, entry: 'foo', check: (String generated) {
+ Expect.isTrue(!generated.contains(r'break'));
+ }),
+ compile(TEST_THREE, entry: 'foo', check: (String generated) {
+ Expect.isTrue(generated.contains(r'continue'));
+ }),
+ compile(TEST_FOUR, entry: 'foo', check: (String generated) {
+ Expect.isTrue(generated.contains(r'continue'));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/logical_expression_test.dart ('k') | tests/compiler/dart2js/minify_many_locals_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698