Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: tests/compiler/dart2js/gvn_test.dart

Issue 326913002: Make dart2js unittests async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/generate_at_use_site_test.dart ('k') | tests/compiler/dart2js/identity_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/gvn_test.dart
diff --git a/tests/compiler/dart2js/gvn_test.dart b/tests/compiler/dart2js/gvn_test.dart
index 150237d48eba143c49f661f71c849574f261bb03..4050222cf4a2a680bacfa805a37c28140677215d 100644
--- a/tests/compiler/dart2js/gvn_test.dart
+++ b/tests/compiler/dart2js/gvn_test.dart
@@ -2,8 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "package:expect/expect.dart";
-import "package:async_helper/async_helper.dart";
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
import 'compiler_helper.dart';
const String TEST_ONE = r"""
@@ -106,33 +107,41 @@ main() {
""";
main() {
- String generated = compile(TEST_ONE, entry: 'foo');
- RegExp regexp = new RegExp(r"1 \+ [a-z]+");
- checkNumberOfMatches(regexp.allMatches(generated).iterator, 1);
-
- generated = compile(TEST_TWO, entry: 'foo');
- checkNumberOfMatches(new RegExp("length").allMatches(generated).iterator, 1);
-
- generated = compile(TEST_THREE, entry: 'foo');
- checkNumberOfMatches(new RegExp("number").allMatches(generated).iterator, 1);
-
- generated = compile(TEST_FOUR, entry: 'foo');
- checkNumberOfMatches(new RegExp("shr").allMatches(generated).iterator, 1);
-
- asyncTest(() => compileAll(TEST_FIVE).then((generated) {
- checkNumberOfMatches(
- new RegExp("get\\\$foo").allMatches(generated).iterator, 1);
- }));
-
- asyncTest(() => compileAll(TEST_SIX).then((generated) {
- Expect.isTrue(generated.contains('for (t1 = a.field === 54; t1;)'));
- }));
-
- asyncTest(() => compileAll(TEST_SEVEN).then((generated) {
- Expect.isTrue(generated.contains('for (t1 = a.field === 54; t1;)'));
- }));
-
- asyncTest(() => compileAll(TEST_EIGHT).then((generated) {
- Expect.isTrue(generated.contains('for (; i < t1; ++i)'));
- }));
+ asyncTest(() => Future.wait([
+ compile(TEST_ONE, entry: 'foo', check: (String generated) {
+ RegExp regexp = new RegExp(r"1 \+ [a-z]+");
+ checkNumberOfMatches(regexp.allMatches(generated).iterator, 1);
+ }),
+
+ compile(TEST_TWO, entry: 'foo', check: (String generated) {
+ checkNumberOfMatches(
+ new RegExp("length").allMatches(generated).iterator, 1);
+ }),
+
+ compile(TEST_THREE, entry: 'foo', check: (String generated) {
+ checkNumberOfMatches(
+ new RegExp("number").allMatches(generated).iterator, 1);
+ }),
+
+ compile(TEST_FOUR, entry: 'foo', check: (String generated) {
+ checkNumberOfMatches(new RegExp("shr").allMatches(generated).iterator, 1);
+ }),
+
+ compileAll(TEST_FIVE).then((generated) {
+ checkNumberOfMatches(
+ new RegExp("get\\\$foo").allMatches(generated).iterator, 1);
+ }),
+
+ compileAll(TEST_SIX).then((generated) {
+ Expect.isTrue(generated.contains('for (t1 = a.field === 54; t1;)'));
+ }),
+
+ compileAll(TEST_SEVEN).then((generated) {
+ Expect.isTrue(generated.contains('for (t1 = a.field === 54; t1;)'));
+ }),
+
+ compileAll(TEST_EIGHT).then((generated) {
+ Expect.isTrue(generated.contains('for (; i < t1; ++i)'));
+ }),
+ ]));
}
« no previous file with comments | « tests/compiler/dart2js/generate_at_use_site_test.dart ('k') | tests/compiler/dart2js/identity_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698