Rename runAsync to scheduleMicrotask.

Rename runAsync to scheduleMicrotask.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28569

[Lasse Reichstein Nielsen, 2013-10-07 07:17:03]

I think scheduleMicrotask might be a little too long a name. We don't have
another easy way to run such a task (new Future(comp) uses Timer, Future.sync is
immediate). Could we have a Future.microtask(comp) constructor so
scheduleMicrotask is really only for low-level implementation of higher level
abstractions?

https://codereview.chromium.org/26151002/diff/2001/pkg/barback/lib/src/utils....
File pkg/barback/lib/src/utils.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/barback/lib/src/utils....
pkg/barback/lib/src/utils.dart:172: // Future.value or Future() constructors use
scheduleMicrotask themselves and
`scheduleMicrotask` or [scheduleMicrotask]

https://codereview.chromium.org/26151002/diff/2001/pkg/mdv/lib/src/input_bind...
File pkg/mdv/lib/src/input_bindings.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/mdv/lib/src/input_bind...
pkg/mdv/lib/src/input_bindings.dart:155: // 2:
This is extremely fragile, and depends on the exact order of the microtask
queue. If something else becomes async, it may fail inexplicably.
I'd prefer if it was abstracted into something that explicitly handled its own
queuing, with a "run a after b" scheduling.

https://codereview.chromium.org/26151002/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/utils.dart:55: // Future.value or Future()
constructors use scheduleMicrotask themselves and
`scheduleMicrotask`.

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.dart
File sdk/lib/async/event_loop.dart (right):

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.d...
sdk/lib/async/event_loop.dart:51: *       asyncRun(foo);  // Schedules [foo] in
front of other events.
asyncRun -> scheduleMicrotask

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.d...
sdk/lib/async/event_loop.dart:72: void asyncRun(void callback()) {
runAsync?

[Lasse Reichstein Nielsen, 2013-10-07 07:17:08]

lgtm

[floitsch, 2013-10-10 16:00:36]

https://codereview.chromium.org/26151002/diff/2001/pkg/barback/lib/src/utils....
File pkg/barback/lib/src/utils.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/barback/lib/src/utils....
pkg/barback/lib/src/utils.dart:172: // Future.value or Future() constructors use
scheduleMicrotask themselves and
On 2013/10/07 07:17:03, Lasse Reichstein Nielsen wrote:
> `scheduleMicrotask` or [scheduleMicrotask]

In normal comments it's ok.

https://codereview.chromium.org/26151002/diff/2001/pkg/mdv/lib/src/input_bind...
File pkg/mdv/lib/src/input_bindings.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/mdv/lib/src/input_bind...
pkg/mdv/lib/src/input_bindings.dart:155: // 2:
On 2013/10/07 07:17:03, Lasse Reichstein Nielsen wrote:
> This is extremely fragile, and depends on the exact order of the microtask
> queue. If something else becomes async, it may fail inexplicably.
> I'd prefer if it was abstracted into something that explicitly handled its own
> queuing, with a "run a after b" scheduling.

Filed dartbug.com/13968

https://codereview.chromium.org/26151002/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/26151002/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/utils.dart:55: // Future.value or Future()
constructors use scheduleMicrotask themselves and
On 2013/10/07 07:17:03, Lasse Reichstein Nielsen wrote:
> `scheduleMicrotask`.

This is a normal comment. No need to dartdocify it.

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.dart
File sdk/lib/async/event_loop.dart (right):

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.d...
sdk/lib/async/event_loop.dart:51: *       asyncRun(foo);  // Schedules [foo] in
front of other events.
On 2013/10/07 07:17:03, Lasse Reichstein Nielsen wrote:
> asyncRun -> scheduleMicrotask

Done.

https://codereview.chromium.org/26151002/diff/2001/sdk/lib/async/event_loop.d...
sdk/lib/async/event_loop.dart:72: void asyncRun(void callback()) {
On 2013/10/07 07:17:03, Lasse Reichstein Nielsen wrote:
> runAsync?

ouch. yes.

[floitsch, 2013-10-12 15:53:17]

Committed patchset #6 manually as r28569 (presubmit successful).