Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: sdk/lib/async/zone.dart

Issue 26151002: Rename runAsync to scheduleMicrotask. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | tests/html/events_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/zone.dart
diff --git a/sdk/lib/async/zone.dart b/sdk/lib/async/zone.dart
index 39ce0c550018b07905e58fdbd43bb278d5c999fc..ed59742bf3b56b67358523c561bd4dac562dfd37 100644
--- a/sdk/lib/async/zone.dart
+++ b/sdk/lib/async/zone.dart
@@ -23,6 +23,9 @@ typedef ZoneBinaryCallback RegisterBinaryCallbackHandler(
Zone self, ZoneDelegate parent, Zone zone, f(arg1, arg2));
typedef void ScheduleMicrotaskHandler(
Zone self, ZoneDelegate parent, Zone zone, f());
+@deprecated
+typedef void RunAsyncHandler(
+ Zone self, ZoneDelegate parent, Zone zone, f());
typedef Timer CreateTimerHandler(
Zone self, ZoneDelegate parent, Zone zone, Duration duration, void f());
typedef Timer CreatePeriodicTimerHandler(
@@ -50,6 +53,8 @@ typedef Zone ForkHandler(Zone self, ZoneDelegate parent, Zone zone,
* Handlers can either stop propagation the request (by simply not calling the
* parent handler), or forward to the parent zone, potentially modifying the
* arguments on the way.
+ *
+ * *The `runAsync` handler is deprecated. Use `scheduleMicrotask` instead.*
*/
abstract class ZoneSpecification {
/**
@@ -71,6 +76,8 @@ abstract class ZoneSpecification {
Zone self, ZoneDelegate parent, Zone zone, f(arg1, arg2)): null,
void scheduleMicrotask(
Zone self, ZoneDelegate parent, Zone zone, f()): null,
+ void runAsync(
+ Zone self, ZoneDelegate parent, Zone zone, f()): null,
Timer createTimer(Zone self, ZoneDelegate parent, Zone zone,
Duration duration, void f()): null,
Timer createPeriodicTimer(Zone self, ZoneDelegate parent, Zone zone,
@@ -99,6 +106,8 @@ abstract class ZoneSpecification {
Zone self, ZoneDelegate parent, Zone zone, f(arg1, arg2)): null,
void scheduleMicrotask(
Zone self, ZoneDelegate parent, Zone zone, f()): null,
+ void runAsync(
+ Zone self, ZoneDelegate parent, Zone zone, f()): null,
Timer createTimer(Zone self, ZoneDelegate parent, Zone zone,
Duration duration, void f()): null,
Timer createPeriodicTimer(Zone self, ZoneDelegate parent, Zone zone,
@@ -125,7 +134,9 @@ abstract class ZoneSpecification {
: other.registerBinaryCallback,
scheduleMicrotask: scheduleMicrotask != null
? scheduleMicrotask
- : other.scheduleMicrotask,
+ : (runAsync != null
+ ? runAsync
+ : other.scheduleMicrotask),
createTimer : createTimer != null ? createTimer : other.createTimer,
createPeriodicTimer: createPeriodicTimer != null
? createPeriodicTimer
@@ -141,6 +152,8 @@ abstract class ZoneSpecification {
RegisterUnaryCallbackHandler get registerUnaryCallback;
RegisterBinaryCallbackHandler get registerBinaryCallback;
ScheduleMicrotaskHandler get scheduleMicrotask;
+ @deprecated
+ RunAsyncHandler get runAsync;
CreateTimerHandler get createTimer;
CreatePeriodicTimerHandler get createPeriodicTimer;
ForkHandler get fork;
@@ -162,11 +175,13 @@ class _ZoneSpecification implements ZoneSpecification {
this.registerCallback: null,
this.registerUnaryCallback: null,
this.registerBinaryCallback: null,
- this.scheduleMicrotask: null,
+ scheduleMicrotask: null,
+ runAsync: null,
this.createTimer: null,
this.createPeriodicTimer: null,
this.fork: null
- });
+ }) : this.scheduleMicrotask =
+ scheduleMicrotask != null ? scheduleMicrotask : runAsync;
// TODO(13406): Enable types when dart2js supports it.
final /*HandleUncaughtErrorHandler*/ handleUncaughtError;
@@ -177,6 +192,8 @@ class _ZoneSpecification implements ZoneSpecification {
final /*RegisterUnaryCallbackHandler*/ registerUnaryCallback;
final /*RegisterBinaryCallbackHandler*/ registerBinaryCallback;
final /*ScheduleMicrotaskHandler*/ scheduleMicrotask;
+ @deprecated
+ get runAsync => scheduleMicrotask;
final /*CreateTimerHandler*/ createTimer;
final /*CreatePeriodicTimerHandler*/ createPeriodicTimer;
final /*ForkHandler*/ fork;
@@ -203,6 +220,8 @@ abstract class ZoneDelegate {
ZoneCallback registerCallback(Zone zone, f());
ZoneUnaryCallback registerUnaryCallback(Zone zone, f(arg));
ZoneBinaryCallback registerBinaryCallback(Zone zone, f(arg1, arg2));
+ @deprecated
+ void runAsync(Zone zone, f());
void scheduleMicrotask(Zone zone, f());
Timer createTimer(Zone zone, Duration duration, void f());
Timer createPeriodicTimer(Zone zone, Duration period, void f(Timer timer));
@@ -354,6 +373,9 @@ abstract class Zone {
*/
void scheduleMicrotask(void f());
+ @deprecated
+ void runAsync(void f());
+
/**
* Creates a Timer where the callback is executed in this zone.
*/
@@ -458,6 +480,11 @@ class _ZoneDelegate implements ZoneDelegate {
(parent._specification.scheduleMicrotask)(parent, grandParent, zone, f);
}
+ @deprecated
+ void runAsync(Zone zone, f()) {
+ scheduleMicrotask(zone, f());
+ }
+
Timer createTimer(Zone zone, Duration duration, void f()) {
_CustomizedZone parent = _degelationTarget;
while (parent._specification.createTimer == null) {
@@ -608,6 +635,11 @@ class _CustomizedZone implements Zone {
new _ZoneDelegate(this).scheduleMicrotask(this, f);
}
+ @deprecated
+ void runAsync(void f()) {
+ scheduleMicrotask(f);
+ }
+
Timer createTimer(Duration duration, void f()) {
return new _ZoneDelegate(this).createTimer(this, duration, f);
}
@@ -805,20 +837,20 @@ dynamic runZoned(body(),
/**
* Deprecated. Use `runZoned` instead or create your own [ZoneSpecification].
*
- * The [onRunAsync] handler (if non-null) is invoked when the [body] executes
- * [runAsync]. The handler is invoked in the outer zone and can therefore
- * execute [runAsync] without recursing. The given callback must be
- * executed eventually. Otherwise the nested zone will not complete. It must be
- * executed only once.
+ * The [onScheduleMicrotask] handler (if non-null) is invoked when the [body]
+ * executes [scheduleMicrotask]. The handler is invoked in the outer zone and
+ * can therefore execute [scheduleMicrotask] without recursing. The given
+ * callback must be executed eventually. Otherwise the nested zone will not
+ * complete. It must be executed only once.
*
* The following example prints the stack trace whenever a callback is
- * registered using [runAsync] (which is also used by [Completer]s and
+ * registered using [scheduleMicrotask] (which is also used by [Completer]s and
* [StreamController]s.
*
* printStackTrace() { try { throw 0; } catch(e, s) { print(s); } }
* runZonedExperimental(body, onRunAsync: (callback) {
* printStackTrace();
- * runAsync(callback);
+ * scheduleMicrotask(callback);
* });
*
* Note: the `onDone` handler is ignored.
@@ -854,7 +886,7 @@ runZonedExperimental(body(),
}
ZoneSpecification specification =
new ZoneSpecification(handleUncaughtError: errorHandler,
- scheduleMicrotask: asyncHandler);
+ scheduleMicrotask: asyncHandler);
Zone zone = Zone.current.fork(specification: specification);
if (onError != null) {
return zone.runGuarded(body);
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | tests/html/events_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698